Repository navigation
Fix collection interior handling - #32
Merged
Merged
Conversation
Owner
|
I read through the code. Overall I don't mind this approach. I'm going to merge. |
Owner
|
Thanks again. I really appreciate it. |
tidwall
pushed a commit
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with me.
Please ensure you adhere to every item in this list
Describe your changes
This PR fixes geometrycollection interior handling, whereby the highest dimension member of the collection's interior is the only one that counts. This affects the touches and containment predicates.
The original approach in apache/sedona-db#1042 counted point, line, and poly interior hits...this approach tracks min/max dimensions and seems to be a bit more succinct. The fix in that PR also doesn't handle touches. I tried to constrain it to just geometry collection paths.
Happy to change the approach here.
Issue number and link
Closes #20.