Conversation
fix dbstats struct missing eight trailing write amplification fields which caused tidesdb get db stats to write past the python allocated buffer and corrupt the heap on every call. fix config struct missing finish compactions on close which made tidesdb open read past the buffer. add the seven trailing write amplification counters to the cf stats struct. all six structs now match the c library sizeof byte for byte. add missing bindings, init, finalize, raise open file limit, compression available, cancel background work, objstore s3 create and objstore s3 create config. the s3 creators are bound lazily so import still works on builds without s3 support and raise a clear error instead of crashing. add finish compactions on close config field across the dataclass, init, open and default config. add the new write amplification fields to stats and db stats with parsing. add tdb err busy error code and message. free txn get values and column family name lists through tidesdb free instead of libc free so a custom allocator stays correct. fix pre existing test that asserted max concurrent flushes default was non zero when the library now reports zero meaning use the library default. add sixteen tests covering the new surface, all one hundred thirty pass. extend the python reference docs with init and process limits, fast shutdown, the s3 connector, compression available, finish compactions on close, the write amplification fields and a full error code table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix dbstats struct missing eight trailing write amplification fields which caused tidesdb get db stats to write past the python allocated buffer and corrupt the heap on every call. fix config struct missing finish compactions on close which made tidesdb open read past the buffer. add the seven trailing write amplification counters to the cf stats struct. all six structs now match the c library sizeof byte for byte.
add missing bindings, init, finalize, raise open file limit, compression available, cancel background work, objstore s3 create and objstore s3 create config. the s3 creators are bound lazily so import still works on builds without s3 support and raise a clear error instead of crashing.
add finish compactions on close config field across the dataclass, init, open and default config. add the new write amplification fields to stats and db stats with parsing. add tdb err busy error code and message. free txn get values and column family name lists through tidesdb free instead of libc free so a custom allocator stays correct.
fix pre existing test that asserted max concurrent flushes default was non zero when the library now reports zero meaning use the library default.
add sixteen tests covering the new surface, all one hundred thirty pass. extend the python reference docs with init and process limits, fast shutdown, the s3 connector, compression available, finish compactions on close, the write amplification fields and a full error code table.