Skip to content

fix: preserve telemetry host during deployment - #51

Merged
Icemap merged 1 commit into
mainfrom
cheese/fix-telemetry-deploy-host-env
Aug 21, 2026
Merged

fix: preserve telemetry host during deployment#51
Icemap merged 1 commit into
mainfrom
cheese/fix-telemetry-deploy-host-env

Conversation

@Icemap

@Icemap Icemap commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • separate the optional workflow input from the application TELEMETRY_PUBLIC_HOST variable
  • prevent an omitted workflow input from overriding the server-side .env with an empty process environment value

Validation

  • git diff --check
  • verified docker compose config --quiet on the deployment host with an empty optional deployment input

Root cause

Docker Compose gives the process environment precedence over --env-file. The workflow exported an empty TELEMETRY_PUBLIC_HOST whenever public_host was omitted, so Compose rejected the otherwise valid server-side configuration before building or restarting the service.

@ti-chi-bot ti-chi-bot Bot added the size/S label Aug 21, 2026
@Icemap
Icemap merged commit 9491fa4 into main Aug 21, 2026
2 checks passed
@Icemap
Icemap deleted the cheese/fix-telemetry-deploy-host-env branch August 21, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant