SCAL-337860:Add support for spotterExperienceVersion=Spotter_2026_11 as enum in SDK - #667
mouryabalabhadra wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the spotterExperience configuration option across AppEmbed, SpotterEmbed, and LiveboardEmbed, allowing users to load the updated Spotter experience (such as Spotter_26_11). It also updates the embed path for SpotterEmbed to use /embed/insights/spotter when this experience is enabled, and adds corresponding unit tests. The review feedback correctly identifies that the JSDoc comments in several files violate the repository's canonical tag ordering rules, where the @version tag must be placed before @example and @group tags.
commit: |
|
@gemini review pr |
There was a problem hiding this comment.
Code Review
This pull request introduces the spotterExperience configuration option across various embed components (AppEmbed, SpotterEmbed, and LiveboardEmbed) to allow loading specific Spotter experience versions (such as Spotter_26_11). It updates the URL parameter generation to include spotterExperience and dynamically adjusts the iframe path for SpotterEmbed when the new experience is selected. Additionally, comprehensive unit tests have been added to verify these behaviors. The reviewer suggested refactoring the path construction in SpotterEmbed to avoid fragile string replacements, which improves maintainability.
|
@copilot review the pr |
Co-authored-by: mouryabalabhadra <[email protected]>
Fixed the public export gap in |
|
@gemini review the pr again |
There was a problem hiding this comment.
Code Review
This pull request introduces the spotterUI configuration option and the SpotterUI enum across AppEmbed, SpotterEmbed, and LiveboardEmbed to support loading specific Spotter UI versions (such as Spotter_2026_11). It handles the corresponding query parameter propagation, updates path resolution for SpotterEmbed, exports the new enum from the SDK root, and adds comprehensive unit tests. However, the JSDoc comments use @version SDK: 1.53.0 | ThoughtSpot Cloud: 26.11.0.cl, which violates the canonical SDK-to-ThoughtSpot version mapping sequence where SDK 1.53.0 should map to ThoughtSpot Cloud 26.10.0.cl.
No description provided.