Skip to content

SCAL-337860:Add support for spotterExperienceVersion=Spotter_2026_11 as enum in SDK - #667

Open
mouryabalabhadra wants to merge 5 commits into
mainfrom
SCAL-337860
Open

mouryabalabhadra wants to merge 5 commits into
mainfrom
SCAL-337860

Conversation

@mouryabalabhadra

Copy link
Copy Markdown
Collaborator

No description provided.

@mouryabalabhadra
mouryabalabhadra requested a review from a team as a code owner September 14, 2026 02:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the spotterExperience configuration option across AppEmbed, SpotterEmbed, and LiveboardEmbed, allowing users to load the updated Spotter experience (such as Spotter_26_11). It also updates the embed path for SpotterEmbed to use /embed/insights/spotter when this experience is enabled, and adds corresponding unit tests. The review feedback correctly identifies that the JSDoc comments in several files violate the repository's canonical tag ordering rules, where the @version tag must be placed before @example and @group tags.

Comment thread src/embed/app.ts
Comment thread src/embed/conversation.ts
Comment thread src/embed/liveboard.ts
Comment thread src/embed/spotter-utils.ts
@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@667

commit: e14f2e1

@mouryabalabhadra mouryabalabhadra changed the title SCAL-337860:Add support for spotterexperience=Spotter_11.26 as enum in SDK SCAL-337860:Add support for spotterExperience=Spotter_11.26 as enum in SDK Sep 15, 2026
@mouryabalabhadra

Copy link
Copy Markdown
Collaborator Author

@gemini review pr

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the spotterExperience configuration option across various embed components (AppEmbed, SpotterEmbed, and LiveboardEmbed) to allow loading specific Spotter experience versions (such as Spotter_26_11). It updates the URL parameter generation to include spotterExperience and dynamically adjusts the iframe path for SpotterEmbed when the new experience is selected. Additionally, comprehensive unit tests have been added to verify these behaviors. The reviewer suggested refactoring the path construction in SpotterEmbed to avoid fragile string replacements, which improves maintainability.

Comment thread src/embed/conversation.ts
@mouryabalabhadra

Copy link
Copy Markdown
Collaborator Author

@copilot review the pr

Co-authored-by: mouryabalabhadra <[email protected]>

Copilot AI commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@copilot review the pr

Fixed the public export gap in a022f66 by re-exporting SpotterExperience from the root SDK and React entry points, and added a regression test to pin the root export.

@mouryabalabhadra mouryabalabhadra changed the title SCAL-337860:Add support for spotterExperience=Spotter_11.26 as enum in SDK SCAL-337860:Add support for spotterUI=Spotter_2026_11 as enum in SDK Sep 16, 2026
@mouryabalabhadra

Copy link
Copy Markdown
Collaborator Author

@gemini review the pr again

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the spotterUI configuration option and the SpotterUI enum across AppEmbed, SpotterEmbed, and LiveboardEmbed to support loading specific Spotter UI versions (such as Spotter_2026_11). It handles the corresponding query parameter propagation, updates path resolution for SpotterEmbed, exports the new enum from the SDK root, and adds comprehensive unit tests. However, the JSDoc comments use @version SDK: 1.53.0 | ThoughtSpot Cloud: 26.11.0.cl, which violates the canonical SDK-to-ThoughtSpot version mapping sequence where SDK 1.53.0 should map to ThoughtSpot Cloud 26.10.0.cl.

@mouryabalabhadra mouryabalabhadra changed the title SCAL-337860:Add support for spotterUI=Spotter_2026_11 as enum in SDK SCAL-337860:Add support for spotterExperienceVersion=Spotter_2026_11 as enum in SDK Sep 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants