[SCAL-336968] Add embed support for Spotter conversation search - #665
Open
heyimalaap wants to merge 1 commit into
Open
heyimalaap wants to merge 1 commit into
heyimalaap wants to merge 1 commit into
Conversation
heyimalaap
commented
Sep 10, 2026
heyimalaap
commented
Collaborator
- spotterSidebarConfig.enableConversationSearch view-config flag to show the search button in the sidebar (embed-only, off by default; forwarded via APP_INIT like the rest of the sidebar config)
- HostEvent.OpenSpotterConversationSearch / CloseSpotterConversationSearch to open/close the search page (open works even with the button hidden)
- EmbedEvent.SpotterConversationSearchToggled ({ open: boolean }) emitted on every open/close of the search page
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Spotter conversation search feature, adding the enableConversationSearch configuration option, corresponding unit tests, the SpotterConversationSearchToggled embed event, and host events to open and close the search page. The feedback suggests changing the string value of the new SpotterConversationSearchToggled enum member to camelCase ('spotterConversationSearchToggled') to maintain consistency with existing Spotter embed events.
- spotterSidebarConfig.enableConversationSearch view-config flag to show
the search button in the sidebar (embed-only, off by default; forwarded
via APP_INIT like the rest of the sidebar config)
- HostEvent.OpenSpotterConversationSearch / CloseSpotterConversationSearch
to open/close the search page (open works even with the button hidden)
- EmbedEvent.SpotterConversationSearchToggled ({ open: boolean }) emitted
on every open/close of the search page
Co-Authored-By: Claude Fable 5 <[email protected]>
commit: |
heyimalaap
force-pushed
the
SCAL-336968
branch
from
September 10, 2026 23:49
12a245b to
7f4d761
Compare
| * spotterEmbed.trigger(HostEvent.OpenSpotterConversationSearch); | ||
| * ``` | ||
| */ | ||
| OpenSpotterConversationSearch = 'OpenSpotterConversationSearch', |
Contributor
There was a problem hiding this comment.
add unit test for host event and embed event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.