SCAL-337466 Send embed config over postMessage instead of the iframe URL - #663
shivam-kumar-ts wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the sendConfigAsPostMessage configuration option, allowing the SDK to send embed configurations via postMessage (HostEvent.UpdateEmbedParams) instead of encoding them directly into the iframe URL. This helps keep the iframe URL short and prevents configuration leakage in the DOM. Only essential bootstrap parameters are kept on the URL. Feedback on the changes points out a duplicate entry of Param.PendoTrackingKey in the BOOTSTRAP_URL_PARAMS set.
f5a9c30 to
123203e
Compare
commit: |
123203e to
f42a093
Compare
|
@gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the sendConfigAsPostMessage option, which allows sending embed configurations via postMessage (HostEvent.UpdateEmbedParams) instead of encoding them in the iframe URL, keeping the URL short and clean. To support this, various embed components were updated to use the new getUrlQueryParamsObject helper, and comprehensive tests were added. Feedback on the changes includes a request to reorder JSDoc tags in src/types.ts to comply with the repository style guide, and to remove a redundant this.viewConfig assignment in the SearchBarEmbed constructor.
062782a to
1d23ad2
Compare
1d23ad2 to
f1693fe
Compare
This branch has not been deployed
1 participant
No description provided.