SCAL-334820 Split Action.Edit into Action.EditLiveboard and Action.Ed… - #660
Open
ts-nk-github-cplot wants to merge 1 commit into
Open
ts-nk-github-cplot wants to merge 1 commit into
ts-nk-github-cplot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new actions, EditLiveboard and EditVisualization, to the Action enum in src/types.ts to allow independent control over editing Liveboards and visualizations. It also adds corresponding unit tests in src/embed/liveboard.spec.ts to verify their independent behavior. There are no review comments, and we have no feedback to provide.
ts-nk-github-cplot
force-pushed
the
SCAL-334820
branch
from
September 8, 2026 10:28
09f6f94 to
a086f64
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…itVisualization
Also ran