Skip to content

Changes of "CenterPoint" to "SpriteCenterPoint" - #13

Open
kottochii wants to merge 1 commit into
thoth-tech:mainfrom
kottochii:sprite-center-point-fix
Open

Changes of "CenterPoint" to "SpriteCenterPoint"#13
kottochii wants to merge 1 commit into
thoth-tech:mainfrom
kottochii:sprite-center-point-fix

Conversation

@kottochii

Copy link
Copy Markdown

Description

Changed occurences of "CenterPoint" to "SpriteCenterPoint", according to the newer documentation, as the previous version stopped running under the newest version of SplashKit.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (update or new)

How Has This Been Tested?

The game runs on the latest version of SplashKit. The former version did not.

Testing Checklist

  • Tested with .NET 10.0

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have requested a review from SK Arcade Team on the Pull Request

@rory-cd rory-cd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Information

This worked for me and is a straight forward fix to the issue, nice work. The only problem is the user will need the latest C# bindings (which include SpriteCenterPoint) - so I believe lib/SplashKit.cs should be updated with the latest bindings.

Approved with this suggested amendment.

I have tested successfully on Windows/MSYS2 with .NET 8.0 and .NET 10.0 as below.

Image

Code Quality

  • Repository: Is this Pull Request is made to the correct repository?
  • Readability: Is the code easy to read and follow?
  • Maintainability: Can this code be easily maintained or extended in the future?

Functionality

  • Correctness: Does the code meet the requirements of the task?
  • Impact on Existing Functionality: Has the impact on existing functionality been considered and tested?

Pull Request Details

  • PR Description: Is the problem being solved clearly described?
  • Checklist Completion: Have all relevant checklist items been reviewed and completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants