Skip to content

chore(google): regenerate SDK 585 options with nested validation fixes - #5341

Closed
thomhurst wants to merge 1 commit into
mainfrom
maintenance/gcloud-options-nested-synopsis-20260922
Closed

thomhurst wants to merge 1 commit into
mainfrom
maintenance/gcloud-options-nested-synopsis-20260922

Conversation

@thomhurst

@thomhurst thomhurst commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Google Cloud SDK 585.0.0 adds 24 commands. This refresh uses the unchanged latest-main workflow artifact after generator fixes in #5328, #5331, #5332, #5334, #5335, #5336, #5337, and #5340. Required nested choices now preserve Storage source combinations, documented custom-context alternatives, complete Agent Identity OAuth branches, and valid Cloud Build trigger updates.

Seven handwritten Google test files adapt required resource constructors and exercise upload alternatives, resource/service contracts, list delimiters, enums, provider requirements, secret metadata, independent SQL/authentication groups, optional resource selectors and TLS bundles. The latest file adds 42 runtime cases for Storage, OAuth, and Cloud Build. Current CLI output remains authoritative; no compatibility shims or generated API baselines are added.

Replacement for closed #5338, #5333, #5315, and #5179; completes runtime coverage from closed #4863, #4869, and #4956. Acceptance issues: #5339, #5180, #5178, #5166, #5146, #4850, #4849, #4799, #4797, and #4474.

Generation: https://github.com/thomhurst/ModularPipelines/actions/runs/35676360503 from main 1be7211. Artifact 10673523529 was applied unchanged and passes reverse-application and latest-main freshness checks. Coverage retains all 7,951 commands and 1,455 groups, adds 24 commands, removes none, and contains all 54 commands reported in #5146 with no exclusions. Generator fingerprint: 41969523ae9657b1a9b01f7e04eaf6a8284dbcb23609fda2b48377ee8bb01bf0.

The generated Google library builds in the workflow; its only failures are the four handwritten constructor calls adapted here. Documentation build passes (331 documents), and no generated API baselines change. Source prerequisite #5340 passes all 3,368 generator tests and all reviews. Local broad validation reached the mandated 2 GB guard; actual Google integration execution in an explicit branch CI run remains required before merge.

Summary by CodeRabbit

  • Documentation
    • Added reference entries for new gcloud app-topology commands, including domain, location, and resource graph operations.
    • Documented gcloud compute image-views commands for viewing image details and listings.
    • Added documentation for Memorystore token authentication user and auth-token management commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-22T02:20:35.302019Z 153fc21 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The CLI reference adds gcloud command entries for App Topology, Compute image views, and Memorystore token authentication.

Changes

Google Cloud CLI documentation

Layer / File(s) Summary
Add gcloud command reference entries
docs/docs/mp-packages/cli/gcloud.md
The command reference adds App Topology commands, Compute image-view commands, and Memorystore token-authentication commands and subcommands.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 153fc

This refresh adds references for newly available Google Cloud CLI commands. The documented paths match the repository command inventory, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The changes address #5338 and #4863. They regenerate the 585.0.0 options, add the required handwritten test coverage, preserve nested and conditional groups, and include the artifact upload alternativ… Provide the explicit-branch Google integration CI result and confirm that the complete runtime suite passes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: regenerating Google SDK 585 options with nested validation fixes. It is concise and specific.
Out of Scope Changes check ✅ Passed The generated library, documentation entries, and handwritten test updates directly support the regeneration and validation objectives in #5338 and #4863. The summary identifies no unrelated product c…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The changes address #5338 and #4863. They regenerate the 585.0.0 options, add the required handwritten test coverage, preserve nested and conditional groups, and include the artifact upload alternatives with optional repository and location selectors. The generated library and documentation builds pass. The complete Google integration runtime suite has not completed, so runtime compliance required by #5338 and #4863 remains unverified.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the command guide
New cloud paths now stand inside
App Topology, images in view
Token-auth commands join the queue
Clear entries hop where users stride

Comment @coderabbitai help to get the list of available commands.

@thomhurst

Copy link
Copy Markdown
Owner Author

Closing because generated validation invents required companions from adjacent SYNOPSIS flags. Confirmed against SDK 585 source: Cluster Director granular updates are optional individually, and OAuth members explicitly have required: false. Evidence and expected generator behavior are recorded in #5339. Source will be fixed separately; this snapshot will not be patched in place.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

if ((!string.IsNullOrWhiteSpace(ExecutableInteractiveTimeoutMillis) || !string.IsNullOrWhiteSpace(ExecutableOutputFile) || !string.IsNullOrWhiteSpace(ExecutableTimeoutMillis) || !string.IsNullOrWhiteSpace(ServiceAccount) || !string.IsNullOrWhiteSpace(ServiceAccountTokenLifetimeSeconds)) && (!(!string.IsNullOrWhiteSpace(ServiceAccount))))

P2 Badge Allow executable timeouts without impersonation

When an executable credential source sets ExecutableInteractiveTimeoutMillis, ExecutableOutputFile, or ExecutableTimeoutMillis without service-account impersonation, this condition rejects the options before invoking gcloud. The adjacent option descriptions identify these as executable-source settings; only ServiceAccountTokenLifetimeSeconds is a child of ServiceAccount. The same incorrect grouping appears in GcloudIamWorkloadIdentityPoolsCreateCredConfigOptions, so the generator should preserve the two independent groups and regenerate both files.

AGENTS.md reference: AGENTS.md:L33-L33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@thomhurst

Copy link
Copy Markdown
Owner Author

Source fix #5342 is open; all 30 focused checks pass. All queued/running CI for this closed PR, including its explicit manual full-pipeline run, has been cancelled and pending work verified at zero. Another latest-main generation will follow source validation and merge.

@thomhurst

Copy link
Copy Markdown
Owner Author

Source fix #5342 is merged as c2ccb29. All 3,379 generator tests pass, and CodeQL, CodeFactor, Claude, CodeRabbit, and Codex are clear. All review findings are addressed, and no pending CI remains on the merged source PR.

Fresh latest-main generation: https://github.com/thomhurst/ModularPipelines/actions/runs/35682446460. The replacement will retain SDK-documented branch optionality while enforcing explicit GKE autoprovisioning dependencies. Sixty-seven handwritten runtime cases are prepared for the Google integration. This issue remains open until the unchanged artifact and actual Google integration CI pass review and validation.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh latest-main replacement: #5344, generated by run 35684123650 after source fixes through #5343. Artifact 10676728248 is unchanged and passes provenance, coverage, and documentation checks. The replacement contains 76 nested-choice runtime cases plus the earlier regression suites. Actual Google integration CI and reviews are pending; acceptance issues remain open until those pass.

@thomhurst

Copy link
Copy Markdown
Owner Author

Fresh latest-main replacement: #5347, generated by run 35690354313 after source fixes through #5346. Artifact 10678711892 is unchanged and passes provenance, coverage, and documentation checks. Compared with rejected #5344, only eight embedded-credential SecretValue annotations and the fingerprint change; no masking annotation is removed.

The replacement retains 76 nested-choice cases and adds runtime attribute checks for all eight credential fields. Explicit integration CI: https://github.com/thomhurst/ModularPipelines/actions/runs/35692851347. Acceptance remains pending actual Google test execution and reviews.

This branch had an error being deployed

1 failed deployment
Pull Requests 153fc219 Deployed Sep 22, 2026 by thomhurst via full pipeline (ubuntu-latest) #17020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant