[Automated] Update gcloud CLI Options - #4953
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Too many files changed for review (1968 files, 100 file limit). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f66715c12f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// All resource record sets for this selector, one per resource record type. The name must match the dns_name. This is a repeated argument that can be specified multiple times to specify multiple local data rrsets. (e.g. --local-data=name="zone.com.",type="A",ttl=21600,rrdata="1.2.3.4 " --local-data=name="www.zone.com.",type="CNAME",ttl=21600,rrdata="1.2.3.4|5.6.7.8") name The DnsName of a resource record set. type Type of all resource records in this set. For example, A, AAAA, SOA, MX, NS, TXT ... ttl Number of seconds that this ResourceRecordSet can be cached by resolvers. rrdatas The list of datas for this record, split by "|". Collection entries are joined with commas into one option value. For entries containing commas, supply one pre-escaped list value using gcloud topic escaping (https://cloud.google.com/sdk/gcloud/reference/topic/escaping). | ||
| /// </summary> | ||
| [CliOption("--local-data", Format = OptionFormat.EqualsSeparated)] | ||
| [CliOption("--local-data", Format = OptionFormat.EqualsSeparated, CollectionSeparator = ",")] |
There was a problem hiding this comment.
Preserve repeated --local-data arguments
When LocalData contains multiple record sets, CollectionSeparator = "," makes CommandArgumentBuilder.AddJoinedOption emit one combined --local-data=...,... argument, but the generated gcloud help immediately above identifies this as a “repeated argument that can be specified multiple times” and demonstrates two separate flags. Because each record set already contains comma-delimited fields such as name, type, ttl, and rrdata, joining the entries loses the record-set boundary and can reject or misapply the DNS update; keep this option repeatable by fixing the generator's list detection and regenerating.
AGENTS.md reference: AGENTS.md:L33-L34
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The scraper fix is now in parent #4869 at e33a493. Explicit repeated-switch descriptions override list-shaped placeholders; captured SDK 550.0.0 DNS help reproduces this defect, and a generated-attribute regression plus a Google rendering test preserve separate record arguments. All 66 focused generator tests pass. Authoritative regeneration is running at https://github.com/thomhurst/ModularPipelines/actions/runs/34818716389. This generated head remains blocked until replaced; no output was hand-edited.
Review: #4953 — Automated gcloud CLI Options UpdateThis is a purely mechanical regeneration from Spot checks performed:
No actionable issues found. This looks safe to merge as a routine generated-options refresh. |
|
Confirmed against f66715c: |
f66715c to
ba40d49
Compare
ReviewThis PR is the automated "Update gcloud CLI options" regeneration. Almost the entire diff (~1968 files) is mechanically-generated However, the commit also carries one real source change to the generator itself, and it introduces a regression: Blocking: dropped null/empty-description guard in
|
Summary
This PR contains automatically generated updates to gcloud CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Gcloud.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Google.Options.GcloudAccessApprovalSettingsUpdateOptions.EnrolledServices.get -> string?ModularPipelines.Google.Options.GcloudAccessApprovalSettingsUpdateOptions.NotificationEmails.get -> string?ModularPipelines.Google.Options.GcloudAssetSearchAllIamPoliciesOptions.OrderBy.get -> string?ModularPipelines.Google.Options.GcloudAssetSearchAllResourcesOptions.OrderBy.get -> string?ModularPipelines.Google.Options.GcloudAssetSearchAllResourcesOptions.ReadMask.get -> string?Representative added members:
ModularPipelines.Google.Options.GcloudAccessApprovalSettingsUpdateOptions.EnrolledServices.get -> System.Collections.Generic.IEnumerable<string!>?ModularPipelines.Google.Options.GcloudAccessApprovalSettingsUpdateOptions.NotificationEmails.get -> System.Collections.Generic.IEnumerable<string!>?ModularPipelines.Google.Options.GcloudAssetSearchAllIamPoliciesOptions.OrderBy.get -> System.Collections.Generic.IEnumerable<string!>?ModularPipelines.Google.Options.GcloudAssetSearchAllResourcesOptions.OrderBy.get -> System.Collections.Generic.IEnumerable<string!>?ModularPipelines.Google.Options.GcloudAssetSearchAllResourcesOptions.ReadMask.get -> System.Collections.Generic.IEnumerable<string!>?Command coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator