[Automated] Update gcloud CLI Options - #4950
Conversation
thomhurst
added
automated
dependencies
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Too many files changed for review (3000 files, 100 file limit). |
💡 Codex Review Keep optional schedule settings out of the constructor
The generated help for AGENTS.md reference: AGENTS.md:L33-L34 Accept the negative form in required flag validation
When a caller sets the generated AGENTS.md reference: AGENTS.md:L33-L34  Preserve gcloud duration syntax for execution timeout
The captured help describes AGENTS.md reference: AGENTS.md:L33-L34 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
test line one |
|
Confirmed the three findings against head 83382e9. The generated schedule constructor requires documented optional defaults, the certificate template validation checks only the positive boolean flags, and execution timeout is emitted as int despite its documented duration syntax. This output PR must remain unmerged. The fixes belong in the generator on parent #4863, followed by regeneration; generated options must not be edited manually. |
|
The three findings in comment 5659907571 are fixed in generator source 16b9bd9 on parent #4863:
Five cases reproduced these failures before the fix; a sixth regression covers the parent's nested at-least-one finding. All 61 final parser tests pass, following an earlier 151-test parser/traversal/Markdown pass. The final generator Release build has zero warnings/errors; scoped formatting and all 61 API baseline checks pass. Broader combined validation hit the unchanged 2,048 MB guard at 2,270 MB and is delegated to CI without retry or increased limits. This output head remains unmerged. Fresh authoritative regeneration is running from the final source at https://github.com/thomhurst/ModularPipelines/actions/runs/34816097702. Its output must replace this snapshot and pass source-provenance, integration, CI, and review gates. No generated options were edited manually. |
83382e9 to
e33dea8
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e33dea8e58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [property: SecretValue, CliOption("--bitbucket-cloud-config-webhook-secret-version", Format = OptionFormat.EqualsSeparated)] string BitbucketCloudConfigWebhookSecretVersion, | ||
| [property: SecretValue, CliOption("--bitbucket-data-center-config-webhook-secret-version", Format = OptionFormat.EqualsSeparated)] string BitbucketDataCenterConfigWebhookSecretVersion, | ||
| [property: CliOption("--bitbucket-data-center-config-service-directory", Format = OptionFormat.EqualsSeparated)] string BitbucketDataCenterConfigServiceDirectory, | ||
| [property: SecretValue, CliOption("--github-config-authorizer-credential-oauth-token-secret-version", Format = OptionFormat.EqualsSeparated)] string GithubConfigAuthorizerCredentialOauthTokenSecretVersion |
There was a problem hiding this comment.
The checked-in gcloud developer-connect connections create help fixture defines the connection configurations as “At most one” (NestedArgumentGroupParsingTests.cs:1470-1488), but this constructor now makes options from Bitbucket Cloud, Bitbucket Data Center, and GitHub mandatory simultaneously. A caller selecting any single provider must therefore emit mutually incompatible switches, while the generated validation at lines 318-348 additionally requires several Bitbucket-only flags and is invoked before command construction. Preserve the nested group's conditionality in the generator and regenerate these options.
AGENTS.md reference: AGENTS.md:L33-L34
Useful? React with 👍 / 👎.
| public enum GcloudAcceleratorType | ||
| { | ||
| [EnumValue("NVIDIA_TESLA_A100")] | ||
| NvidiaTeslaA100, | ||
|
|
||
| [EnumValue("NVIDIA_TESLA_K80")] | ||
| NvidiaTeslaK80, | ||
|
|
||
| [EnumValue("NVIDIA_TESLA_P100")] | ||
| NvidiaTeslaP100, | ||
|
|
||
| [EnumValue("NVIDIA_TESLA_P100_VWS")] | ||
| NvidiaTeslaP100Vws, | ||
| [EnumValue("NVIDIA_A100_80GB")] | ||
| NvidiaA100_80Gb, |
There was a problem hiding this comment.
GcloudNotebooksRuntimesSwitchOptions.Generated.cs:43-47 still uses this enum while documenting supported values such as NVIDIA_TESLA_K80, NVIDIA_TESLA_P100, NVIDIA_TESLA_P4, TPU_V2, and TPU_V3, but this regeneration removed all of those members and retained only the narrower Colab/Workbench value set. Consumers using those valid notebook accelerator types can no longer represent the CLI input through the typed option, and existing code referencing the removed members stops compiling. Aggregate choices from every command sharing the enum name and regenerate the output.
AGENTS.md reference: AGENTS.md:L33-L34
Useful? React with 👍 / 👎.
Review summaryThis PR is a scheduled/dispatched run of the Finding: the PR silently bundles a generator-source (logic) change inside what's described as a pure data regenerationThe PR body says "The generator scraped the latest CLI help output from the installed tool" and lists only data-level changes (options classes, types, descriptions, new commands). But comparing base ( The refactor itself looks behavior-preserving on inspection (straightforward extract-method + regex pre-compilation + a logging guard), and
Suggestion: since the workflow already computes Other checks
No action needed from the PR author here — this is a process/tooling gap in the automation, not a defect in this specific PR's generated content. |
1 participant
Summary
This PR contains automatically generated updates to gcloud CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Assembly/common,Gcloud.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaA100 = 0 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaK80 = 1 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP100 = 2 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP100Vws = 3 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaP4 = 4 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeRepresentative added members:
ModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaA100_80Gb = 0 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaL4 = 1 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaA100 = 2 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaT4 = 3 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeModularPipelines.Google.Enums.GcloudAcceleratorType.NvidiaTeslaV100 = 4 -> ModularPipelines.Google.Enums.GcloudAcceleratorTypeCommand coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator