Conversation
…out of required positionals Two regressions from #4470 broke the cargo regeneration (#4692): - CargoCliScraper only read option rows under headings containing "option" or ending in "selection", so clap's `Source:` and `Section:` groups on `cargo add`/`cargo remove` (--path, --git, --branch, --dev, ...) vanished from the generated options. Every heading is now an option section except the positional, command and prose ones (Arguments, Commands, Examples, ...). - UsageSynopsisParser treated an operand attached to an option (`--path <PATH>`) as a positional slot when deciding whether an operand missing from an alternate usage form is still required. With `[OPTIONS]` ahead of every form the phases matched, so `<DEP>` stayed a required constructor parameter even though `--path`/`--git` are alternatives to it. Option-attached operands no longer count as positional slots. Regenerated cargo from cargo 1.98.0 (the same tree as the baseline) and recorded provenance; the only generated change is the explicit IValidatableObject.Validate implementation the generator now emits, and CargoOptionsTests compiles and passes unchanged. Closes #4692 Claude-Session: https://claude.ai/code/session_01PkLNTUfwGXjqXZrYrHaDGC
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryUpdates Cargo 1.98.1 generation metadata and synchronizes the Rust integration’s public API baselines with its generated Cargo option classes.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified. The metadata is internally consistent, the public API entries align with generated Cargo sources, and validation preserves CargoAdd’s required dependency-source contract.
|
| Filename | Overview |
|---|---|
| src/ModularPipelines.Rust/Generated/Cargo.CommandCoverage.json | Updates the recorded Cargo patch version while preserving the 16-command coverage tree. |
| src/ModularPipelines.Rust/Generated/Cargo.Generation.json | Updates Cargo provenance to the new tool version and generator-source fingerprint. |
| src/ModularPipelines.Rust/PublicAPI.Shipped.txt | Removes regenerated CargoAddOptions members from the shipped API baseline so their removals can be tracked. |
| src/ModularPipelines.Rust/PublicAPI.Unshipped.txt | Records CargoAddOptions removals and the newly exposed generated Cargo option APIs. |
Reviews (1): Last reviewed commit: "chore: Update cargo CLI options" | Re-trigger Greptile
ReviewAutomated cargo CLI options regeneration — no actionable issues found. What changed: Only generated/metadata files are touched ( Verified:
No prior reviewer comments (CodeRabbit skipped since the base isn't Since this is generated output, per repo policy it should be accepted as-is rather than hand-edited. |
c0cf690 to
672df5c
Compare
|
Do not incorporate this snapshot: #4722 was rebased onto current main and received additional operand-identity fixes at 672df5c. This output records the previous generator source. Replacement authoritative Cargo generation is running at https://github.com/thomhurst/ModularPipelines/actions/runs/34790317773 and will use the new source-ref branch naming. Retaining this PR until the replacement is available for comparison. |
|
Superseded by #4887, regenerated successfully from the corrected, rebased #4722 source at 672df5c. The old branch contains one generated metadata/baseline commit atop c0cf690; its handwritten source changes are the pre-rebase parent history, not unique work. #4887 preserves Cargo 1.98.1 and all 16 commands and is receiving current feature-target CI. Keeping the old branch for provenance; no generated files were hand-edited. |
Summary
This PR contains automatically generated updates to cargo CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Assembly/common,Cargo.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Rust.Options.CargoAddOptions.CargoAddOptions(System.Collections.Generic.IEnumerable<string!>! Dep) -> voidModularPipelines.Rust.Options.CargoAddOptions.Deconstruct(out System.Collections.Generic.IEnumerable<string!>! Dep) -> voidModularPipelines.Rust.Options.CargoAddOptions.Dep.get -> System.Collections.Generic.IEnumerable<string!>!ModularPipelines.Rust.Options.CargoAddOptions.Dep.init -> voidstatic ModularPipelines.Rust.Extensions.CargoExtensions.Cargo(this ModularPipelines.IPipelineContext! context) -> ModularPipelines.Rust.Services.ICargo!Representative added members:
ModularPipelines.Rust.Options.CargoAddOptions.Base.get -> string?ModularPipelines.Rust.Options.CargoAddOptions.Base.set -> voidModularPipelines.Rust.Options.CargoAddOptions.Branch.get -> string?ModularPipelines.Rust.Options.CargoAddOptions.Branch.set -> voidModularPipelines.Rust.Options.CargoAddOptions.Build.get -> bool?Command coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator