Skip to content

[Automated] Update brew CLI Options - #4873

Closed
thomhurst wants to merge 3 commits into
issue-4848-generated-service-awaitsfrom
automated/update-cli-options-brew-issue-4848-generated-service-awaits
Closed

thomhurst wants to merge 3 commits into
issue-4848-generated-service-awaitsfrom
automated/update-cli-options-brew-issue-4848-generated-service-awaits

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

This PR contains automatically generated updates to brew CLI options classes.

The generator scraped the latest CLI help output from the installed tool.

Changes

  • Updated options classes to reflect latest CLI documentation
  • Added new commands if any were detected
  • Updated option types and descriptions

Assembly-wide public API impact

Affected API families: Assembly/common, Brew.

  • Added APIs: 52
  • Removed or changed APIs: 0
  • Members with matching names but changed signatures: 0

Representative added members:

  • ModularPipelines.Homebrew.Options.BrewFindAppcastOptions
  • ModularPipelines.Homebrew.Options.BrewFindAppcastOptions.AppPath.get -> string!
  • ModularPipelines.Homebrew.Options.BrewFindAppcastOptions.AppPath.init -> void
  • ModularPipelines.Homebrew.Options.BrewFindAppcastOptions.BrewFindAppcastOptions(ModularPipelines.Homebrew.Options.BrewFindAppcastOptions! original) -> void
  • ModularPipelines.Homebrew.Options.BrewFindAppcastOptions.BrewFindAppcastOptions(string! AppPath) -> void

Command coverage

Command coverage report:

  • brew (Homebrew 6.0.22): 124 commands, tree b9bc491964db5025a9226c50ddcd5931068c38239471e3e36517ca999bfc5c4c
    • Baseline comparison: 122 commands at Homebrew 6.0.20 -> 124 commands at Homebrew 6.0.22
    • Added: brew find-appcast, brew generate-cask-token

Verification

  • Solution builds successfully

🤖 Generated with ModularPipelines.OptionsGenerator

@thomhurst thomhurst added automated dependencies Pull requests that update a dependency file labels Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f8aa398e-e2a4-42f9-8c1c-6a1e149461ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T17:51:15.416207Z 2cacb71 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown

Greptile Summary

This automated regeneration updates the Homebrew integration from Homebrew 6.0.20 to 6.0.22.

  • Adds typed options and service APIs for brew find-appcast and brew generate-cask-token.
  • Adds the brew tests --shard option and refreshes several command descriptions.
  • Updates command-coverage metadata, documentation, and the recorded public API.
  • Regenerates Brew service awaits with ConfigureAwait(false) as required for library code.

Confidence Score: 5/5

The PR appears safe to merge; the generated options, service methods, metadata, documentation, and public API are mutually consistent.

No actionable failures were identified. The new commands follow established argument and service patterns, while existing command behavior remains unchanged apart from the required synchronization-context handling.

Important Files Changed

Filename Overview
src/ModularPipelines.Homebrew/Options/BrewFindAppcastOptions.Generated.cs Adds the generated typed options record for brew find-appcast, including its required app-path operand and standard flags.
src/ModularPipelines.Homebrew/Options/BrewGenerateCaskTokenOptions.Generated.cs Adds the generated typed options record for brew generate-cask-token, including its required application-or-name operand.
src/ModularPipelines.Homebrew/Options/BrewTestsOptions.Generated.cs Adds equals-separated serialization support for the new --shard option.
src/ModularPipelines.Homebrew/Services/Brew.Generated.cs Implements the two new commands and consistently applies ConfigureAwait(false) to generated service awaits.
src/ModularPipelines.Homebrew/Services/IBrew.Generated.cs Exposes matching public interface methods for the two newly supported Brew commands.
src/ModularPipelines.Homebrew/PublicAPI.Unshipped.txt Records the newly generated option types, members, shard property, and service methods.

Reviews (1): Last reviewed commit: "chore: Update brew CLI options" | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Review: [Automated] Update brew CLI Options (#4873)

This is a fully machine-generated regeneration of the brew CLI options from Homebrew 6.0.20 → 6.0.22, produced by ModularPipelines.OptionsGenerator. I compared it against the generator/options conventions in CLAUDE.md and against sibling generated files.

What's in the diff:

  • Two new subcommands: BrewFindAppcastOptions (brew find-appcast) and BrewGenerateCaskTokenOptions (brew generate-cask-token), each with a single required positional string argument plus the standard --debug/--quiet/--verbose/--help flags — shape matches existing single-arg subcommands like BrewFormulaOptions/BrewFetchOptions.
  • A new --shard option on BrewTestsOptions.
  • Doc-comment-only refreshes on BrewAuditOptions.Fix, BrewContributionsOptions.MaintainerReportCsv, and BrewTapOptions to match upstream --help text.
  • Mechanical companions: PublicAPI.Unshipped.txt, Brew.CommandCoverage.json, Brew.Generation.json, and docs/docs/mp-packages/cli/brew.md all updated consistently with the new/changed members.
  • Brew.Generated.cs/IBrew.Generated.cs also pick up .ConfigureAwait(false) on every awaited call — consistent with the src/ convention and with the PR's base branch (issue-4848-generated-service-awaits), which is the in-progress work adding these awaits to generated services. Nothing here looks hand-edited or out of step with that effort.

All of this is generated output, so per repo guidance I did not suggest hand-edits to the generated files — any real fix belongs in the scraper/generator. I didn't find anything to fix there either: the new option classes, flag mappings, and doc comments all look correctly scraped and are structurally identical to neighboring generated subcommands.

One thing worth flagging for awareness rather than as a blocking defect: this PR's base branch is issue-4848-generated-service-awaits, not main. That's presumably why CodeRabbit reported "Review skipped ... Auto reviews are disabled on base/target branches other than the default branch." Worth confirming that targeting a non-default feature branch here is intentional (e.g. to avoid churn until that branch merges) rather than a misconfiguration of the automation's target-branch selection.

No prior human review comments existed on this PR to reconcile against (only bot noise from CodeRabbit and Codex).

Verdict: No actionable findings — generated output looks correct and consistent.

@thomhurst
thomhurst force-pushed the issue-4848-generated-service-awaits branch from 7f2288d to 4dbd41a Compare September 13, 2026 19:53
@thomhurst

Copy link
Copy Markdown
Owner Author

Generated output is incorporated in #4872 (c5dd508, confirmed in remote head 4dbd41a). Homebrew Release build and its integration test pass. Closing this intermediate PR; #4872 remains open for fresh regeneration, validation, and review before merging to main.

@thomhurst thomhurst closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant