Repository navigation
CI: probe embedding the 3.15t wasm build without main (#175 step 2) - #411
Merged
Merged
Conversation
Exports wasmExports, wasmMemory and wasmTable from the free-threaded wasm build and adds a node probe step to build-ft-wasm.yml: the shared memory, a non-shared versus shared memory import (what Kotlin/Wasm emits versus what a patch would emit), and Py_Initialize from the JS main thread with four threads and gc.collect() in a worker. The step runs after the archive upload, so a probe failure does not lose the archive.
Member
Author
|
Run 43393844607 (build-ft-wasm.yml, ubuntu): success.
Note: emcc warns that EXPORTED_FUNCTIONS is ignored with MAIN_MODULE (all functions are exported anyway), so the _malloc/_free/_Py_Version append is a no-op on 3.15.0. Merge waits for the leader's macOS CI hold (a develop push starts the desktop/ios gates). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #175 (step 2; the issue stays open).
Adds a probe step to build-ft-wasm.yml (ubuntu only) that checks what the library's wasmJs target would need from the free-threaded pthreads build:
LinkError: mismatch in shared state of memoryversus success.build-wasm.sh appends wasmExports, wasmMemory and wasmTable to -sEXPORTED_RUNTIME_METHODS (asserted) and _malloc, _free, _Py_Version to -sEXPORTED_FUNCTIONS when that list exists. The probe step runs after the archive upload, so its failure does not lose the archive. Node only: node's main thread uses a real Atomics.wait, a browser busy-waits.
Agent proposal toward #175 step 2, not a decision. Investigation: Kotlin/Wasm has no shared-memory option, so the library cannot load against this build without a binary patch of the import or a compiler change (decisions recorded for the owner).