Repository navigation
test: fix golden file path collisions and add map helper integration tests - #12
Merged
thisisibrahimd merged 2 commits intoSep 3, 2026
Merged
Conversation
…tests - Flatten golden test directories and prefix filenames with parent test name to avoid file collisions - Update assertRender calls to pass test name explicitly - Add integration tests for mapXyz and mapXyzByName helpers with golden fixtures - Document nested map helper limitation in README
thisisibrahimd
enabled auto-merge
September 3, 2026 13:45
thisisibrahimd
disabled auto-merge
September 3, 2026 13:46
- Add flattened golden test fixtures for builder and docsonnet tests - Add golden fixtures for jsonschemacompiler tests - Add map helper integration test with fixtures and generator script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make testAll tests passing (10 packages).