Repository navigation
test(builder): add golden tests, fuzz, benchmarks, and doc comments - #10
Merged
Merged
Conversation
Convert all builder package tests to table-driven format with golden files. Add fuzz tests for escapeKey, Marshal, indent, and dedent. Add property-based tests for invariants. Add benchmarks for rendering performance. Add Go doc comments to all public types and functions. - 108 golden files across 18 test types - Coverage increased from 89.8% to 96.6% - All golden output validated as syntactically valid Jsonnet - New test files: fuzz, property, benchmark, doc, operators, comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive testing improvements for the
pkg/builderpackage — the core code generator for Jsonnet Kubernetes libraries.Builder Test Improvements
go-jsonnet/formatteras syntactically valid JsonnetResults
New Files
pkg/builder/TESTING.md— testing guidepkg/builder/fuzz_test.go— fuzz testspkg/builder/property_test.go— property-based testspkg/builder/benchmark_test.go— performance benchmarkspkg/builder/doc_test.go— Doc type testspkg/builder/operators_test.go— ArithType + SprintfType testspkg/builder/comments_test.go— CommentType + RequiredArg + CallArg testspkg/builder/testdata/— 108 golden fixture files