Repository navigation
Typecheck in GitHub Actions on every PR - #27
Merged
Merged
Conversation
The Cloudflare build is the only required check, and `astro build` doesn't typecheck, so a type error in a component could merge as long as the site still built. This runs `npm run check` on every PR and push to main, as a "Typecheck" job the main ruleset can require. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cloudflare build is the only required check, and
astro builddoesn't typecheck, so a type error in a component could merge as long as the site still built. This runsnpm run checkon every PR and push to main, as a "Typecheck" job the main ruleset can require.