Skip to content

chain-dma: fix NULL dereference #11016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyakh wants to merge 1 commit into from
+2 −2
Closed

chain-dma: fix NULL dereference #11016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/schedule/zephyr_ll.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ static void zephyr_ll_task_done(struct zephyr_ll *sch,

task->state = SOF_TASK_STATE_FREE;

if (pdata->freeing)
if (pdata && pdata->freeing)

@ujfalusi ujfalusi Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real issue is with the 48cdc4d + CONFIG_USERSPACE=y
this combination causes the ChainDMA crash on PTL and only on PTL as CONFIG_USERSPACE=y is only set for PTL, all other platform has USERSPACE disabled.
it boils down to some difference due to the use of kernel/sys/sem.c vs kernel/userspace/sem.c for semaphore.

Reverting the commit or disabling USERSPACE fixed the crash on PTL.

@lyakh lyakh Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi agree, that's why I wrote that last sentence in the PR description.

/*
* zephyr_ll_task_free() is trying to free this task. Complete
* it and signal the semaphore to let the function proceed
Expand Down Expand Up @@ -258,7 +258,7 @@ static void zephyr_ll_run(void *data)
task = container_of(list, struct task, list);
pdata = task->priv_data;

if (task->state == SOF_TASK_STATE_CANCEL) {
if (!pdata || task->state == SOF_TASK_STATE_CANCEL) {
list = list->next;
zephyr_ll_task_done(sch, task);
continue;
Expand Down
Loading