Skip to content

Improve 64-bit Linux and retail Prey compatibility - #32

Closed
bobmoser76 wants to merge 12 commits into
themuffinator:mainfrom
bobmoser76:fix-linux-64bit-math
Closed

bobmoser76 wants to merge 12 commits into
themuffinator:mainfrom
bobmoser76:fix-linux-64bit-math

Conversation

@bobmoser76

Copy link
Copy Markdown
Contributor

Summary:

  • fix 64-bit math, script VM, PVS, hashing, networking, thread-handle, and asset-loading assumptions
  • rename the staged runtime content directory from basepy to basepr
  • improve retail collision, AAS, savegame, particle, renderer, audio, GUI, and gameplay compatibility
  • recover players from overlapping collision seams without slow or jittering movement
  • fix the Linux shutdown segmentation fault caused by truncated pthread handles

GameLib dependency:

Validation:

  • full Meson client, dedicated-server, and unified game-module build completed
  • Meson staging install completed
  • affected quicksave replay maintained stable ground height and normal walking velocity
  • shutdown exits normally under GDB and directly with status 0
  • git diff --check passes

Local generated binaries, diagnostic captures, and retail/local content overlays were intentionally excluded.

@themuffinator

Copy link
Copy Markdown
Owner

Thank you for the breadth of work here.

Since you opened it, main has been replaced by the new-prey rebase. openPREY now sits on a much newer openQ4 engine, the game library is in-tree, basepy is already basepr, and tracked binaries are gone. Much of this was already fixed there in other ways: 64-bit thread handles, MD4, the loading-screen throttle, image preload, AAS 1.07 records, script object restore, and voice-over muting and subtitles.

#34 ports the parts that still applied, credited to you. It also covers #28 and #29:

  • PVS bit vectors on LP64
  • NULL activators at level ends and player starts
  • unsaved render-entity fields after a load (the whole struct is reset, so newer fields are covered too)
  • Unbind() before Event_Remove deletes an entity
  • onActionRelease-only GUI windows counting as interactive. Retail guis/vehicles/shuttle1.gui has no onAction, so this is very likely Docked shuttle interaction #15.
  • NULL material guards in R_GlobalShaderOverride and R_AddDrawSurf
  • a failed SIOCGIFCONF no longer being fatal
  • Linux fs_cdpath beside the executable
  • voice-over left out of the channel-cushion fade

Not taken as they stand, because they depart from retail, change save compatibility or treat a symptom:

  • the savegame version and checksum leniency (main is on its own save version)
  • the denser default fog
  • disabling portal view blocks
  • delayed corpse removal while in view
  • the safeDeathVolume origin test
  • the >32-shard fracture shortcut
  • the forcefield bounds repair
  • the vehicle-as-player trigger
  • the voice-over volume floor in UpdateHardware

The player seam recovery, the monster head refresh, the AAS/CM CRC tolerance and the declared particle bounds may be worth revisiting with a reproduction on current main. If you still hit any of those, an issue with a save, or a map and a position, would be very welcome.

Closing as superseded by #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants