Repository navigation
Resolve config [[table]] glob './/x' like './x' - #1665
Open
thekevinbot wants to merge 4 commits into
Open
thekevinbot wants to merge 4 commits into
thekevinbot wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1629
A config
[[table]] globwritten.//a/*.jsonnow anchors at the config directory with globa/*.json, as bash reads it (bash -O globstar:.//a/*.jsonexpands to the same file as./a/*.json).config_anchor_asstripped./but kept the leftover/, so the glob matched nothing. It now trims the separators after./, asresolve_asalready does for path-tables.Red (test-only commit 04bbe6a, failing for the asserted reason —
left: Some(("/cfg", "//a/*.json"))): https://github.com/thekevinscott/dirsql/actions/runs/42127724414/job/127596107854Sibling #1627 (
..folding in config globs) is a different code path (absolute_target/normalize) and is not addressed here.Changelog / Migrations
packages/rust/changelog.d/2026-11-05-config-glob-dot-double-slash.mdpackages/rust/migrations.d/E2E Verification
cargo test --test config_anchor --lib)packages/python/e2e-attestations/<branch>.jsonreceipt writtenpackages/ts/e2e-attestations/<branch>.jsonreceipt writtencd packages/python && uv run maturin develop --release;cargo build --release -p dirsql --features clitesting-conventions e2e attest 'uv run python -m pytest tests/e2e/declared_table_name_test.py tests/e2e/fanout_test.py tests/e2e/fresh_declared_repros_test.py tests/e2e/on_file_value_types_test.py tests/e2e/on_file_failure_test.py tests/e2e/query_contract_test.py tests/e2e/root_at_construction_test.py tests/e2e/relative_root_chdir_test.py tests/e2e/use_case_transcripts_test.py -x -q'cd packages/ts && pnpm build;testing-conventions e2e attest 'pnpm exec vitest run --dir tests/e2e declared-table-name fanout fresh-declared-repros query-contract root-at-construction'[{"dd":1,"single":1}].