Repository navigation
Unescape backslashes in literal path-table text - #1651
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1599
A
\in the literal text of a glob now quotes the next character, as bash does:path(./do\cs/*.md,./my\ dir/*.md,./do\cs/api.md,./\do\cs), and in a Unix absolute or config-anchor prefix (/var/lo\g/*.log);./\.env,./*/\.draft.md);.gitignoreexemption (./a\.log,./{a\.log,b}).The matcher now sets globset's
backslash_escapeexplicitly, so\escapes on Windows too (it was a literal\that never matched a/-separated path). A\in a Windows drive-letter or UNC prefix still separates. Newdocs/reference/glob.mdconformance rows, each checked againstbash -O globstar -O nullglob.Red
Red tests pushed first in
65082c5f:packages/rust/tests/path_table_escapes_cli_e2e.rs(CLI e2e) andpackages/rust/tests/path_table_escapes.rs(integration). Red run: https://github.com/thekevinscott/dirsql/actions/runs/41943079000/job/126968458420 (all three integration tests fail withleft: [], expecteddocs/api.md,.env,a.log).E2E Verification
cargo test --workspace --features cli: pass (includes the new CLI e2e andglob_conformance).uv run maturin develop --release,cargo build --release -p dirsql --features cli):testing-conventions e2e attest 'uv run python -m pytest tests/e2e/query_contract_test.py tests/e2e/glob_speed_dotfiles_test.py tests/e2e/glob_speed_gitignore_test.py -x -q': 13 passed.pnpm build):testing-conventions e2e attest 'pnpm exec vitest run --dir tests/e2e query-contract': 9 passed.Changelog / Migrations
packages/rust/changelog.d/packages/rust/migrations.d/