Repository navigation
Conversation
This was referenced Oct 2, 2026
Merged
Odilhao
reviewed
Oct 2, 2026
| id-token: write | ||
|
|
||
| steps: | ||
| - uses: voxpupuli/ruby-release@v0 |
Member
There was a problem hiding this comment.
Why can't we keep using the voxpupuli one as we use in all other repos? We need to fix the gemspec to make it work.
Member
Author
There was a problem hiding this comment.
The gemspec lists man/hammer.1.gz because it needs to ship in the gem, but that file must be generated before gem build. Removing it would make the build pass while dropping the man page.
I raised this in voxpupuli/ruby-release#13, where ekohl suggested starting with a longer Hammer-specific workflow that separates building from publishing. This PR follows that approach, keeping build steps outside the job with publishing permissions. I prefer shared tooling too, but we’d need support for generated files or a prebuilt gem, not just a gemspec change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag releases fail because
gem buildrequiresman/hammer.1.gz, which is generated and not tracked. Build the man page and gem in a read-only job, then transfer the gem to a separate job with RubyGems OIDC publishing permission. Check that the built gem's versioned filename matches the tag before uploading it.Related upstream issue: voxpupuli/ruby-release#13
This follows the split-workflow approach discussed in voxpupuli/ruby-release#13 (comment) and needs no upstream action change. The workflow filename and
releaseenvironment are unchanged. Documentation tooling is installed without recommendations to avoid unnecessary TeX dependencies; no application bundle is installed.Validation:
git diff --checkpass.Backport the workflow to
5.0-stableand3.19-stablebefore future release tags. The latter also needs the unprefixed tag pattern. Existing tags are not moved or republished by this change.