Skip to content

Pass EDITOR arguments as an array to system - #406

Merged
Odilhao merged 2 commits into
theforeman:3.19-stablefrom
Odilhao:3.19-release-01-oct
Oct 1, 2026
Merged

Odilhao merged 2 commits into
theforeman:3.19-stablefrom
Odilhao:3.19-release-01-oct

Conversation

@Odilhao

@Odilhao Odilhao commented Oct 1, 2026

Copy link
Copy Markdown
Member

Run the configured EDITOR as an argument array instead of a shell command, so shell metacharacters are not interpreted. Add tests for editor arguments and shell injection cases.

Bump hammer_cli to 3.19.1.

@Odilhao
Odilhao force-pushed the 3.19-release-01-oct branch from 8d560d8 to 0245602 Compare October 1, 2026 15:43
@Odilhao
Odilhao force-pushed the 3.19-release-01-oct branch from 0245602 to 68de1e0 Compare October 1, 2026 15:46
@Odilhao
Odilhao merged commit 7d904dd into theforeman:3.19-stable Oct 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants