Skip to content

Pass EDITOR arguments as an array to system - #405

Merged
Odilhao merged 2 commits into
theforeman:5.0-stablefrom
Odilhao:5.0-release-01-oct
Oct 1, 2026
Merged

Odilhao merged 2 commits into
theforeman:5.0-stablefrom
Odilhao:5.0-release-01-oct

Conversation

@Odilhao

@Odilhao Odilhao commented Oct 1, 2026

Copy link
Copy Markdown
Member

Run the configured EDITOR as an argument array instead of a shell command, so shell metacharacters are not interpreted. Add tests for editor arguments and shell injection cases.

Bump hammer_cli to 5.0.1.

@ofedoren

ofedoren commented Oct 1, 2026

Copy link
Copy Markdown
Member

It's kinda weird to bump the version as the part of this commit, but 🤷

@Odilhao
Odilhao force-pushed the 5.0-release-01-oct branch from 00c5edf to ec71ebb Compare October 1, 2026 15:43
@Odilhao
Odilhao force-pushed the 5.0-release-01-oct branch from ec71ebb to 3a93da3 Compare October 1, 2026 15:46
@Odilhao

Odilhao commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

It's kinda weird to bump the version as the part of this commit, but 🤷

I usually bump the release in a 2nd commit when it's only one commit to avoid tagging other folks for 2 PRs.

@Odilhao
Odilhao merged commit 17571d2 into theforeman:5.0-stable Oct 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants