Repository navigation
Fix release tag pattern and drop redundant manual gem push - #660
Merged
Merged
Conversation
The Release workflow only triggered on 'v*' tags, but the release notebook has always tagged plain versions (e.g. 3.19.0), so automated publishing to rubygems.org has never actually fired since it was added. Also remove the notebook's manual `gem push` step now that the tag push triggers automated, trusted-publishing gem release via CI.
zjhuntin
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseGitHub Actions workflow only triggers on tags matchingv*, but the release notebook (rel-eng/gem_release.ipynb) has always tagged plain versions like3.19.0— so automated publishing to rubygems.org has never actually fired since the workflow was added.*so it matches our actual tagging convention.gem pushstep, since the tag push now triggers automated, trusted-publishing gem release via CI — keeping both would race or fail on a duplicate version push.Test plan
Releaseworkflow fires and successfully publishes to rubygems.org when the next version tag (5.0.0) is pushed.