Skip to content

Wait for tasks in backup integration tests - #895

Open
jakduch wants to merge 1 commit into
theforeman:masterfrom
jakduch:fix/894-backup-tests-wait-for-tasks
Open

jakduch wants to merge 1 commit into
theforeman:masterfrom
jakduch:fix/894-backup-tests-wait-for-tasks

Conversation

@jakduch

@jakduch jakduch commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Why are you introducing these changes? (Problem description, related links)

The backup success-path fixture can run while Foreman still has asynchronous tasks in progress, which makes the command correctly refuse to start and turns otherwise successful integration runs red.

Closes issue #894.

What are the changes introduced in this pull request?

  • Run the backup integration command with --wait-for-tasks.
  • Add a focused assertion for the exact command built by the fixture.
  • Keep the production default fail-fast behavior unchanged.

How to test this pull request

Steps to reproduce:

  • OBSAH_STATE=/private/tmp/foremanctl-894-state python -m pytest tests/backup_test.py::test_backup_command_waits_for_tasks -vv
  • ruff check tests/backup_test.py

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (not applicable)

This change was prepared with AI assistance.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 549beb4a-3713-49ee-8510-741a5e67f5d6
📥 Commits

Reviewing files that changed from the base of the PR and between 98a588e and f60a74c.

📒 Files selected for processing (1)
  • tests/backup_test.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jakduch jakduch mentioned this pull request Sep 27, 2026
2 tasks done
@jakduch

jakduch commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

The current exact-head failure is in the fapolicyd content-proxy job: all containers disappear and subsequent commands fail with /bin/bash: Operation not permitted. That shared cache-exhaustion problem is addressed by #893; the backup task-wait change is not involved. I am leaving this branch unchanged until #893 is available.

@jakduch
jakduch force-pushed the fix/894-backup-tests-wait-for-tasks branch from f32f55d to dbb648b Compare September 30, 2026 12:53
@jakduch
jakduch force-pushed the fix/894-backup-tests-wait-for-tasks branch from dbb648b to f60a74c Compare October 5, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait for Foreman tasks in backup integration tests

1 participant