Conversation
5fe9467 to
feb639e
Compare
a757829 to
a7faf2e
Compare
|
Moving to draft as this will need a rebase and update to match the current state of the code base. |
90ad408 to
b1948f3
Compare
- Use OS-specific package names for IPA Apache modules (mod_* on RedHat, libapache2-mod-* on Debian) - On RedHat: load modules via conf files in conf.modules.d - On Debian: enable modules via apache2_module (a2enmod) - Add httpd_ipa_packages and httpd_ipa_load_modules to both RedHat.yaml and Debian.yaml vars
Add OS-specific vars files for hammer role to use correct package naming conventions (hammer-cli-plugin-* on RedHat, ruby-hammer-cli-* on Debian). Load OS vars via include_vars and remove hardcoded package name pattern from defaults.
- Fix spurious space in httpd_conf_path variable expansion - On RedHat: remove module conf files from conf.modules.d - On Debian: disable modules via apache2_module (a2dismod) - Use httpd_ipa_load_modules flag to select correct method
Ran the Hammer deployment and its feature tests on Debian after adding OS-specific package names.
1416454 to
573c2d5
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Rebased onto the current |
Used the OS-specific Apache account for Foreman and Pulp systemd sockets so Debian does not fail with status 217/USER.
|
The first rebased CI run exposed one real Debian failure: |
|
The latest run had two real Debian packaging failures in addition to the Vagrant Cloud 502s. I fixed the Hammer mapping so plugin underscores become Debian package hyphens ( |
|
The Debian job exposed one more package mapping issue: the official trixie repository has The separate |
8f1445d to
91dc232
Compare
|
The Debian job got past the initial Hammer deployment and then failed in |
|
The fresh Debian job on 91dc232 has passed both |
|
Found the Debian test failure in the fresh job. Apache is enabled by the package before the role writes its Fixed in e58f67e by explicitly ensuring the idempotent wants link before daemon reload. The existing httpd and target lifecycle integration checks cover the link and stop/start behavior. Local YAML/diff checks and all 16 focused unit tests pass. The separate |
|
Also fixed the independent Debian SELinux test failure in 103127c. The test now checks contexts only when SELinux is actually enabled and uses the OS-specific Apache config/module paths. Ruff, diff checks, and collection of all 27 httpd tests pass locally. |
|
I checked all 14 current matrix failures individually. Every one fails only in Ansible/Python lint are green, and the Debian job is still running. |
|
Fixed the remaining Debian-specific test gaps in 9421116:
The focused regression checks pass locally (19 tests). The remaining |
|
The fresh head run is blocked before any branch code executes. I checked all 15 failed jobs individually; every one fails only in The Debian job also confirms the new split is applied ( This external failure is covered by #886, which is fully green and mergeable. I am not starting another blind rerun while Vagrant Cloud is still returning 502s. |
|
Verified the current heads. PR #427 at 9421116 and its In run 36273545722, all 15 executing jobs fail in Because PR #886 targets |
Rebased onto the current
debianbranch. Changes that are already present in the base branch, including Debian repository setup, were dropped during the rebase.The remaining changes:
a2enmod/a2dismodwhere appropriatehttpd_conf_pathexpansion in the external-auth cleanup task