Repository navigation
Serve the docs favicon from public/ so Slack can unfurl links - #68
Merged
Merged
Conversation
Blume inlines a favicon in the docs root as a base64 data URI in every page's <head>, ahead of the Open Graph tags. Slackbot only reads the first 32 KB of a page, so a large enough icon hides the tags from it. This site was still under the limit, but moving the icon to public/ makes Blume link it by URL like the other docs sites and keeps og:image near the top.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Daniel Schmidt · project thread
Blume inlines a favicon in the docs root as a base64 data URI in every page's
<head>, ahead of the Open Graph tags. Slackbot only reads the first 32 KB of a page, so a big enough icon hides the tags and Slack shows no preview. That's what broke the API OIDC and App Translations docs (umbraco-api-oidc#20, umbraco-app-translations#71).This site was still under the limit, but it gets the same fix so every docs site matches:
favicon.pngmoves toapps/docs/public/, andgenerate-brand.mjsnow writes it there. The PNG is unchanged. A localpnpm buildputsog:imageat about byte 2,200 ofindex.html.