Repository navigation
fix: raise the Microsoft.OpenApi floor to 2.12.2 - #64
Merged
Merged
Conversation
Umbraco 18.2.1 depends on Microsoft.OpenApi >= 2.12.2. The 2.11.0 floor made restores against Umbraco 18.2.1 fail with NU1605 (package downgrade, warning as error), which broke the Umbraco 18.* CI job.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Umbraco 18.2.1 depends on
Microsoft.OpenApi2.12.2 or newer, butsrc/TheBuilder.WebAnalytics/TheBuilder.WebAnalytics.csprojreferences 2.11.0. When CI restores against Umbraco 18.2.1, NuGet treats that as a downgrade (NU1605, warning as error), so the ".NET (Umbraco 18.*)" job fails on every branch, includingmainon its next run.This raises the version to 2.12.2. It's still a minimum, as the comment above those references describes ("at or above the versions Umbraco's transitive graph requires"), and Umbraco 17.1 and 17.x accept 2.12.2.
Testing
Ran the CI job's command (
dotnet test tests/TheBuilder.WebAnalytics.Tests/TheBuilder.WebAnalytics.Tests.csproj --configuration Release -p:UmbracoVersion=<version>) locally for each version in the matrix:17.1.0: 233 of 233 tests pass17.*: 233 of 233 tests pass18.*: 233 of 233 tests pass, resolving Umbraco 18.2.1 with Microsoft.OpenApi 2.12.2Unblocks #63.