feat: find-or-create Mattermost channels - #3
Merged
Conversation
Kit can open a team channel via ChannelCreate, artisan kit:channel, or mm create. #mesa-studio is already live (9sp18hgiaiybtj9p5nm8uw3sna). Find-or-create, then optional member add.
![lexi-chief-of-staff[bot]](https://avatars.githubusercontent.com/in/3490641?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ship it.
- ChannelCreate + Client methods implement find-or-create correctly with slugging, member adds, and 404-driven creation path.
- Tests cover existing, create+add, and slug normalization; all assertions match observed behavior.
- Config and command wiring consistent with existing Mattermost setup; no new patterns introduced that contradict codebase.
- No blocking issues on correctness, error paths, or test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hallway is already up on Odin MM:
9sp18hgiaiybtj9p5nm8uw3sna(open)This PR is the tool so we do not curl that by hand again.
ChannelCreate(Kit tool)php artisan kit:channel mesa-studio --add=jordan,lexi~/.grok/kit/mm create mesa-studio "mesa-studio" "purpose" jordan,lexiFind-or-create. Does not post as a second mouth.
Config:
KIT_MATTERMOST_TEAM,KIT_MATTERMOST_HALLWAY,KIT_MATTERMOST_DM. MouthKIT_MATTERMOST_CHANNELstays the Jordan DM until the hallway PR retargets assign/watchdog.Test plan
php artisan test(15 passed on this branch)vendor/bin/pint --testkit:channel mesa-studio→ exists + same id