Repository navigation
fix(editor): use current note path for attachment uploads - #59
Merged
Merged
Conversation
# Conflicts: # app/flowix-web/features/document/components/document-container.session.test.tsx # app/flowix-web/features/editor/extensions/attachment-link/upload/storage.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolve attachment ownership from the current note path when clipboard paste, file insertion, drag and drop, or file selection starts. Chunked upload requests now send this path as
notePathtobegin_attachment_upload.Why
The editor remains mounted across note renames and notebook selection changes. Attachments need to remain associated with the note being edited and its owning notebook throughout these operations.
How tested
Validation used Node.js 20.20.2.
vitest run document-container.session chunked.test storage.test --maxWorkers=2— 4 test files, 40 tests. Includes screenshot paste while another notebook is selected and paste, insertFiles, and drop after renaming without remounting the editor.npm run check:layers.npm run check:frontend-debt.vitest run --maxWorkers=4— 1,968 passed, 48 failed, with 28 unhandled errors across 271 test files.npm run buildstops at four TypeScript errors: TS2339 inreference-picker.tsx:82, TS18049 intable-secondary-views.tsx:284, and TS2769 inpopover.test.tsx:114and:116. The same four errors were reproduced withtsc --noEmiton upstreammainat031dee50e28e0954bb95fb55f0d9fb1397261d4d.Risks
Full frontend validation is currently failing. Native desktop manual verification is pending.
Checklist
.envfiles touched.main.