Repository navigation
fix: prefer native CSS.escape for form values - #737
Open
rajanpanth wants to merge 1 commit into
Open
rajanpanth wants to merge 1 commit into
rajanpanth wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #720.
toHaveFormValuesnow prefers the form document's nativeCSS.escapeimplementation when it is available, and falls back to the existingcss.escapepackage otherwise. Using the form'sownerDocument.defaultViewkeeps this scoped to the DOM instance being asserted, which works better for jsdom/multi-window cases than reading a process-wide global.The existing dependency remains as a compatibility fallback, so this is a non-breaking first step toward reducing reliance on the package where native support exists.
Validation
npm install --no-package-lock --ignore-scripts --prefer-offlinenpx prettier --check src/to-have-form-values.js src/__tests__/to-have-form-values.jsnpx eslint src/to-have-form-values.js src/__tests__/to-have-form-values.jsCI=1 npm test -- --runInBand src/__tests__/to-have-form-values.jsgit diff --checkNote: the focused Jest run passes in both configured projects (
nodeandjsdom). It prints the repo's existing Jest config warning aboutwatchPlugins, unrelated to this change.