Repository navigation
fix: skip docker-php server plugins for the factory HTTP client - #79
Merged
Merged
Conversation
✅ Deploy Preview for testcontainers-php ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shyim
previously approved these changes
Oct 23, 2026
shyim
reviewed
Oct 23, 2026
shyim
approved these changes
Oct 24, 2026
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78.
The client from
DockerClientFactory::createFromEnv()already adds the daemon address and the negotiated API path, soDocker::create()getsapplyServerPlugins: falsefor it, as the docker-php docs describe. An injected HTTP client factory keeps the server plugins.The new unit test runs a stub daemon on PHP's built-in server that reports API 1.41 and checks that requests go to
/v1.41/infoonly. I also checked a container start and stop against Podman 4.9.