Skip to content

Publish RCs from a dispatched workflow run - #886

Merged
ice1080 merged 2 commits into
mainfrom
dispatch-publish-rc
Oct 2, 2026
Merged

ice1080 merged 2 commits into
mainfrom
dispatch-publish-rc

Conversation

@ice1080

@ice1080 ice1080 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

npm trusted publishing rejects OIDC tokens from issue_comment runs with
"package not found", so commenting "publish rc" on a PR could never
publish. Keep the comment trigger, but have it dispatch the Publish RC
workflow on the PR's branch, so the publish runs as a workflow_dispatch
event that npm accepts.

Also stop logging RC publishes verbosely, now that the cause is known.

Co-Authored-By: Claude Opus 5.5 [email protected]


Stack created with GitHub Stacks CLI • Give Feedback 💬

npm trusted publishing rejects OIDC tokens from issue_comment runs with
"package not found", so commenting "publish rc" on a PR could never
publish. Keep the comment trigger, but have it dispatch the Publish RC
workflow on the PR's branch, so the publish runs as a workflow_dispatch
event that npm accepts.

Also stop logging RC publishes verbosely, now that the cause is known.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

To increment version on merge, please add one of patch (default), minor, or major label to this PR.

@github-actions github-actions Bot added the patch label Oct 2, 2026
@ice1080

ice1080 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

publish rc

@ice1080

ice1080 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

This won't work until it's merged because issue_comment always uses the workflow file on main, so has to be merged first to test it

@ice1080
ice1080 marked this pull request as ready for review October 2, 2026 20:01
@ice1080
ice1080 requested a review from a team as a code owner October 2, 2026 20:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T20:04:57.806959Z c91f06e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c91f06ebc5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish-rc-comment.yaml
Comment thread .github/workflows/publish-rc-comment.yaml
@ice1080
ice1080 merged commit a69c69f into main Oct 2, 2026
1 check passed
@ice1080
ice1080 deleted the dispatch-publish-rc branch October 2, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants