Skip to content

Defer schedule catchup window default to server#1646

Closed
chaptersix wants to merge 1 commit into
mainfrom
codex/schedule-catchup-window-default
Closed

Defer schedule catchup window default to server#1646
chaptersix wants to merge 1 commit into
mainfrom
codex/schedule-catchup-window-default

Conversation

@chaptersix

@chaptersix chaptersix commented Jul 14, 2026

Copy link
Copy Markdown

What changed

  • Change the default SchedulePolicy.catchup_window from an SDK-defined year to None.
  • Omit the protobuf field when it is unset.
  • Preserve absent fields as None when decoding.
  • Add serialization and server-backed default coverage.
  • Update the changelog.

Why

The server owns the default. Materializing one year in the SDK prevents server-side default changes from applying consistently.

Breaking changes

An unconfigured policy now exposes None before it is sent to the server. Described schedules continue to expose the server-resolved duration.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chaptersix chaptersix marked this pull request as ready for review July 15, 2026 15:51
@chaptersix chaptersix requested a review from a team as a code owner July 15, 2026 15:51
Comment thread CHANGELOG.md

### Fixed

- Schedule policies now omit an unspecified catch-up window so the Temporal Server applies its

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this needs a breaking change notification.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, on seconds thought. I think it's fine to for an SDK to default to a year.

@chaptersix chaptersix closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants