Conversation
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
tjpalmer
commented
Sep 12, 2026
| val paramTypes = ctxSig.requiredInputTypes.drop( | ||
| if (sig.hasThisFormal || isSuperCall) 1 else 0, | ||
| ) | ||
| val paramTypes = ctxSig.requiredInputTypes |
Contributor
Author
There was a problem hiding this comment.
Apparently, contextualized signatures drop this automatically now.
| throw TemperBubble(); | ||
| } | ||
| return promise->get(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
New way of doing this for exceptioning backends.
| connectedNames = listOf("UnpackOkResult"), | ||
| builtinOperatorId = BuiltinOperatorId.UnpackOkResult, | ||
| useDot = true, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
These all map in pretty straightforward ways. We use them as values instead of pointers, though, so I added that useDot option.
| Ft.TypesIntBasics, | ||
| Ft.TypesIntLimits, | ||
| Ft.TypesListEmpty, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I think this matches what was there before #474.
tjpalmer
marked this pull request as ready for review
September 12, 2026 02:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hsas an error handling primitive. #474