Keep commit disclosure renders local - #385
Open
open-session-os-tella-dev[bot] wants to merge 1 commit into
Open
open-session-os-tella-dev[bot] wants to merge 1 commit into
open-session-os-tella-dev[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 OS review · approve · quality 5/5 · risk lowSafe to merge. 🟢 Risk low · recovery in minutes
Reviewed |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The workspace summary kept its "Committed" disclosure state in
WorkspaceSummaryBody. Opening that disclosure re-rendered the whole data-heavy summary, including PR status, review, changes, and asset sections.This moves only the disclosure state and unchanged committed-row markup into
CommittedSection. Opening the list now renders that section instead of the full summary. No memoization was added.User-facing hot path
Open a session with committed work and expand "Committed" in the workspace summary. This path is available in the desktop summary card and the phone workspace-details sheet.
Reproduction
verify-opensessionand open/session/bks-demo-prat 1440x900.agent-react-devtoolsbefore loading the headed Chrome page.Benchmark
Medians across three measured runs after one warm-up:
WorkspaceSummaryBody)CommittedSection)The seeded example has one commit. Longer commit lists will still render their rows when opened; this change only avoids re-running unrelated summary work.
Validation
bun test packages/core/opensession-server/src/frontend/components/WorkspaceSummary.test.tsbun run typecheckbun run checkBehavior preservation
The same button, accessible expanded state, collapsed totals, commit order, row renderers, and commit-detail popovers remain in place. State ownership moved to the smallest component that reads and changes it. Product copy, styling, APIs, and data-fetch timing are unchanged.
Limitations
The profiler used the repository's development demo bundle because that is where the React DevTools connector is available. The production bundle also uses the React Compiler, so absolute production timings may differ. Measurements cover the seeded one-commit workspace on local hardware, not a large real workspace or production data.
Started by Jaap Frolich in this OS session