Skip to content

Keep commit disclosure renders local - #385

Open
open-session-os-tella-dev[bot] wants to merge 1 commit into
mainfrom
auto-daily-open-session-react-performance-202609130700-os-01a09990-e698-71ec-824b-a4dcad283962
Open

open-session-os-tella-dev[bot] wants to merge 1 commit into
mainfrom
auto-daily-open-session-react-performance-202609130700-os-01a09990-e698-71ec-824b-a4dcad283962

Conversation

@open-session-os-tella-dev

Copy link
Copy Markdown
Contributor

What changed

The workspace summary kept its "Committed" disclosure state in WorkspaceSummaryBody. Opening that disclosure re-rendered the whole data-heavy summary, including PR status, review, changes, and asset sections.

This moves only the disclosure state and unchanged committed-row markup into CommittedSection. Opening the list now renders that section instead of the full summary. No memoization was added.

User-facing hot path

Open a session with committed work and expand "Committed" in the workspace summary. This path is available in the desktop summary card and the phone workspace-details sheet.

Reproduction

  1. Launch an isolated demo instance with verify-opensession and open /session/bks-demo-pr at 1440x900.
  2. Start agent-react-devtools before loading the headed Chrome page.
  3. Expand and collapse "Committed 1" once as a warm-up.
  4. Profile one expansion, collapse outside the profile, and repeat for three measured runs.
  5. Export each React DevTools profile and compare commit duration, rendered component count, and the slow-component report.
  6. Repeat the interaction after the change with the same demo data, viewport, and browser.

Benchmark

Medians across three measured runs after one warm-up:

Metric Before After Delta
React commits 2 2 0%
Components rendered across commits 83 39 -53.0%
Total commit time 15.4 ms 10.2 ms -33.8%
Disclosure-owning component render 5.9 ms (WorkspaceSummaryBody) 1.3 ms (CommittedSection) -78.0%

The seeded example has one commit. Longer commit lists will still render their rows when opened; this change only avoids re-running unrelated summary work.

Validation

  • bun test packages/core/opensession-server/src/frontend/components/WorkspaceSummary.test.ts
  • bun run typecheck
  • bun run check
  • Headed demo interaction at 1440x900
  • Headed demo interaction at 390x844 through the workspace-details sheet

Behavior preservation

The same button, accessible expanded state, collapsed totals, commit order, row renderers, and commit-detail popovers remain in place. State ownership moved to the smallest component that reads and changes it. Product copy, styling, APIs, and data-fetch timing are unchanged.

Limitations

The profiler used the repository's development demo bundle because that is where the React DevTools connector is available. The production bundle also uses the React Compiler, so absolute production timings may differ. Measurements cover the seeded one-commit workspace on local hardware, not a large real workspace or production data.

Started by Jaap Frolich in this OS session

@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

🤖 OS review · approve · quality 5/5 · risk low

Safe to merge.

🟢 Risk low · recovery in minutes
A revert restores the UI on the next deploy; no persisted state or delivered artifacts remain changed.

  • No tests: WorkspaceSummary.tsx changes runtime UI state ownership without test changes.

Reviewed a5c5837 · GPT-5.6 Sol · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
opensession Ready Ready Preview Sep 13, 2026 7:13am UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants