Skip to content

Keep scoped weekly budgets visible in native model settings - #368

Open
kentdebruin wants to merge 1 commit into
mainfrom
report-keep-weekly-scope-visible
Open

kentdebruin wants to merge 1 commit into
mainfrom
report-keep-weekly-scope-visible

Conversation

@kentdebruin

Copy link
Copy Markdown
Contributor

Change

  • Name the scope beside the weekly header percentage.
  • Keep bare account names separate from scope badges, using OS1VisualStyle.
  • Preserve VoiceOver labels and provider/account pinning.

macOS keeps its native submenu. The iOS 26 capture showed that SwiftUI ignores .badge inside menus, so the iPhone weekly entry opens a native budget sheet with fixed-size scope badges instead.

Verification

  • bun run check passed.
  • OS1 simulator and OS1Mac arm64 builds passed with Xcode 26.6.
  • All 26 AccountUsageTests passed, including scoped/general headers, another model bucket, spoken wording and the depleted long-name fixture.
  • Captured the iPhone sheet with Michael-Tella-Engineering-S…, a fully visible Fable badge and 0% left. Evidence is in this OS session. Debug reproduction: OS1_WEEKLY_REMAINING_FIXTURE=1, then Session actions → Model settings → Weekly remaining.

Started by Kent de Bruin in this OS session

@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
🕙 Outdated review — superseded by a newer review below

🤖 OS review · approve · quality 5/5 · risk low

Safe to merge. No actionable defects found in the diff or its callers; native builds and UI captures were not independently rerun.

🟢 Risk low · recovery in minutes
A revert restores budget presentation; no persisted-data reinterpretation, external delivery, or lasting output changes are shown.

  • Secrets or config: SessionView.swift adds debug-only OS1_WEEKLY_REMAINING_FIXTURE environment override for account pools.

Reviewed d8f5d56 · GPT-6 Astra · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
opensession Ready Ready Preview Sep 11, 2026 3:52pm UTC

@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
🕙 Outdated review — superseded by a newer review below

🤖 OS review · approve · quality 5/5 · risk low

Safe to merge. The new HEAD only rebases the previously approved patch, and the updated integration remains sound.

🟢 Risk low · recovery in minutes
A revert restores the settings UI; no persisted data, external delivery, or unrecoverable output is changed.

Reviewed da699a6 · GPT-5.6 Sol · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

Name the model bucket beside the header percentage and reserve a separate scope badge beside each account name. iOS ignores badges inside native menus, so open the weekly overview in a native sheet there; macOS keeps its submenu. Preserve spoken labels and provider/account pin selection.

Co-authored-by: Kent de Bruin <[email protected]>
@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

🤖 OS review · approve · quality 5/5 · risk low

Safe to merge. The refreshed base introduces no conflicts with the previously approved implementation.

🟢 Risk low · recovery in minutes
A revert restores the settings UI; no persisted data or delivered artifacts are changed.

Reviewed f8765ae · GPT-5.6 Sol · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant