Keep scoped weekly budgets visible in native model settings - #368
kentdebruin wants to merge 1 commit into
Conversation
🕙 Outdated review — superseded by a newer review below🤖 OS review · approve · quality 5/5 · risk lowSafe to merge. No actionable defects found in the diff or its callers; native builds and UI captures were not independently rerun. 🟢 Risk low · recovery in minutes
Reviewed |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d8f5d56 to
da699a6
Compare
🕙 Outdated review — superseded by a newer review below🤖 OS review · approve · quality 5/5 · risk lowSafe to merge. The new HEAD only rebases the previously approved patch, and the updated integration remains sound. 🟢 Risk low · recovery in minutes Reviewed |
Name the model bucket beside the header percentage and reserve a separate scope badge beside each account name. iOS ignores badges inside native menus, so open the weekly overview in a native sheet there; macOS keeps its submenu. Preserve spoken labels and provider/account pin selection. Co-authored-by: Kent de Bruin <[email protected]>
da699a6 to
f8765ae
Compare
🤖 OS review · approve · quality 5/5 · risk lowSafe to merge. The refreshed base introduces no conflicts with the previously approved implementation. 🟢 Risk low · recovery in minutes Reviewed |
Change
macOS keeps its native submenu. The iOS 26 capture showed that SwiftUI ignores
.badgeinside menus, so the iPhone weekly entry opens a native budget sheet with fixed-size scope badges instead.Verification
bun run checkpassed.Michael-Tella-Engineering-S…, a fully visible Fable badge and 0% left. Evidence is in this OS session. Debug reproduction:OS1_WEEKLY_REMAINING_FIXTURE=1, then Session actions → Model settings → Weekly remaining.Started by Kent de Bruin in this OS session