Refresh verification UI selectors - #339
open-session-os-tella-dev[bot] wants to merge 1 commit into
Conversation
Update the archive and session recipes to use the roles and filter controls exposed by the current web UI. Co-authored-by: Kent de Bruin <[email protected]>
🤖 OS review · request changes · quality 2/5 · risk lowSafe once the P2 findings below are fixed. The refreshed recipe still documents selectors and a root title that do not match the current UI. 🟢 Risk low · recovery in minutes 2 inline comments below. Reviewed 🔁 Not merge-ready and no live session owns this branch — add the |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![open-session-os-tella-dev[bot]](https://avatars.githubusercontent.com/u/65127121?s=60&v=4){kind=small}
| - Demo session `bks-demo-pr` exists with title `Fix flaky upload retry test`. | ||
|
|
||
| - **Open a direct session link.** Run `verify-opensession browser "$RUN_ID" open --route /session/bks-demo-pr --width 1440 --height 900`. Wait with `verify-opensession browser "$RUN_ID" wait --role heading --name "Fix flaky upload retry test"`. The session title and transcript appear. | ||
| - **Open a direct session link.** Run `verify-opensession browser "$RUN_ID" open --route /session/bks-demo-pr --width 1440 --height 900`, then capture a snapshot. Require the root accessible title to be `Fix flaky upload retry test` and the seeded transcript to appear. |
There was a problem hiding this comment.
🟠 P2 — Require the workspace title instead of the session title
The root accessibility node is named from document.title, and SessionViewer sets that to workspaceName || session.title. The demo hero is filed into a worktree-grouped workspace whose generated name is its branch, demo/fix-flaky-upload, so a settled snapshot does not have Fix flaky upload retry test as its root title. This makes the refreshed verification requirement fail or race workspace loading. Require the current workspace/root title from the snapshot, while checking the session title separately in the tab or transcript.
| - **Open a direct session link.** Run `verify-opensession browser "$RUN_ID" open --route /session/bks-demo-pr --width 1440 --height 900`, then capture a snapshot. Require the root accessible title to be `Fix flaky upload retry test` and the seeded transcript to appear. | |
| - **Open a direct session link.** Run `verify-opensession browser "$RUN_ID" open --route /session/bks-demo-pr --width 1440 --height 900`, then capture a snapshot. Require the root accessible title to match the session's current workspace title and the seeded `Fix flaky upload retry test` session and transcript to appear. |
| - **Clear and filter.** Refill the search textbox with an empty value, choose the `Filters` button using the exact accessible name from the current snapshot, and select one visible repository or person. Capture the filter state and narrowed result list. | ||
| - **Open the index.** Run `verify-opensession browser "$RUN_ID" open --route /archived --width 1440 --height 900`. Wait for searchbox `Search archived sessions` and capture the unfiltered state. | ||
| - **Search.** Run `verify-opensession browser "$RUN_ID" fill --role searchbox --name "Search archived sessions" --value "retry"`. The visible results narrow to archived work matching `retry`, or an explicit no-results state appears if the seed's archive rules changed. | ||
| - **Clear and filter.** Refill the searchbox with an empty value, then take a fresh snapshot. Choose one of the individually named filter buttons, such as `Owner, My archived`, `Repository, All repositories`, or `Reason, Any reason`, and select a visible option. The repository and reason controls only appear when the loaded archive has choices for them. Capture the filter state and narrowed result list. |
There was a problem hiding this comment.
🟠 P2 — Use the filter buttons' actual accessible names
Two documented exact names do not match Archived.tsx: the repository trigger renders Repository, All repos, while the reason trigger renders Reason, All. Because verify-opensession requires exact accessibility matches, following either example fails whenever that optional control is present. Replace those examples with the rendered labels.
| - **Clear and filter.** Refill the searchbox with an empty value, then take a fresh snapshot. Choose one of the individually named filter buttons, such as `Owner, My archived`, `Repository, All repositories`, or `Reason, Any reason`, and select a visible option. The repository and reason controls only appear when the loaded archive has choices for them. Capture the filter state and narrowed result list. | |
| - **Clear and filter.** Refill the searchbox with an empty value, then take a fresh snapshot. Choose one of the individually named filter buttons, such as `Owner, My archived`, `Repository, All repos`, or `Reason, All`, and select a visible option. The repository and reason controls only appear when the loaded archive has choices for them. Capture the filter state and narrowed result list. |
Summary
Verification
verify-20260910-060141-3535958at desktop and phone widthsbun run checkStarted by Daily verification skill maintenance in this OS session