Skip to content

Keep Open Session verification recipes runnable - #328

Open
open-session-os-tella-dev[bot] wants to merge 1 commit into
mainfrom
auto-daily-verification-skill-maintenance-202609090600-os-01a084c0-a532-7684-adba-3a1ecb73e302
Open

open-session-os-tella-dev[bot] wants to merge 1 commit into
mainfrom
auto-daily-verification-skill-maintenance-202609090600-os-01a084c0-a532-7684-adba-3a1ecb73e302

Conversation

@open-session-os-tella-dev

Copy link
Copy Markdown
Contributor

Summary

  • seed isolated demo data before the gateway and SessionKernel load their catalogs
  • update stale session, archive, and settings accessibility recipes
  • document the archive setup needed for a deterministic restore check

Verification

  • bun run check
  • full source review of all five verification feature files
  • live isolated pass at desktop and phone widths with run verify-20260909-retry-060626-2801968
  • launcher fix re-proved after a clean relaunch and doctor check

Product gap found

Automation creation did not persist in the isolated demo. Both a template flow and a plain scheduled form closed after Create automation, but GET /api/automations and the state directory contained no new automation. Existing automation toggle persistence worked. The run also logged repeated React Maximum update depth exceeded errors around the failed create flow. Product code is intentionally untouched here.

Started by Daily verification skill maintenance in this OS session

Seed demo state before services load their catalogs, and update stale accessibility roles and archive setup steps found in the full verification pass.

Started by Daily verification skill maintenance in this OS session:
https://os.tella.dev/session/os-01a084c0-a532-7684-adba-3a1ecb73e302

Co-authored-by: Daily verification skill maintenance <309495949+open-session-os-tella-dev[bot]@users.noreply.github.com>
@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

🤖 OS review · request changes · quality 4/5 · risk low

Safe once the P2 below is fixed. One recipe currently exercises a different disclosure than it claims.

🟢 Risk low · recovery in minutes
Changes only seed isolated verification state before startup and update verification documentation, so reverting restores behavior.

1 inline comment below.

Reviewed cf8d6bf · GPT-5.6 Sol · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

🔁 Not merge-ready and no live session owns this branch — add the os-auto-fix label and I'll fix the findings automatically.

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
opensession Ready Ready Preview Sep 9, 2026 6:26am UTC

@open-session-os-tella-dev open-session-os-tella-dev Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS review · cf8d6bf

- **Open a direct session link.** Run `verify-opensession browser "$RUN_ID" open --route /session/bks-demo-pr --width 1440 --height 900`. Wait with `verify-opensession browser "$RUN_ID" wait --role heading --name "Fix flaky upload retry test"`. The session title and transcript appear.
- **Inspect transcript semantics.** Run `verify-opensession browser "$RUN_ID" snapshot`. The tree contains the upload retry prompt and transcript controls. Capture a screenshot after expanding any collapsed tool call through its visible button.
- **Open a direct session link.** Run `verify-opensession browser "$RUN_ID" open --route /session/bks-demo-pr --width 1440 --height 900`. Wait with `verify-opensession browser "$RUN_ID" wait --role button --name "Show what this turn wrote to upload.ts"`. The workspace and seeded transcript appear. The page title may use the branch name instead of the session title.
- **Inspect transcript semantics.** Run `verify-opensession browser "$RUN_ID" snapshot`. The tree contains the upload retry prompt and transcript controls. Expand the collapsed tool call with `verify-opensession browser "$RUN_ID" click --role button --name "Show what this turn wrote to upload.ts"`, then capture a screenshot.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 P2 — The transcript recipe does not expand a tool call

Show what this turn wrote to upload.ts is the TurnFooter file-diff popover trigger (TurnFooter.tsx:375-390), while collapsed tool calls are separate buttons whose aria-expanded state is owned by ToolCallBlock.tsx:469-474. Running this command successfully opens the turn-level diff but leaves every tool call collapsed, so a broken tool disclosure would still pass this recipe. Either describe and verify the file-diff popover, or use the current snapshot to click the actual tool-call button before capturing proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants