Skip to content

Review label forces a re-review of an already-reviewed head - #320

Open
soutar wants to merge 1 commit into
mainfrom
review-label-forces
Open

soutar wants to merge 1 commit into
mainfrom
review-label-forces

Conversation

@soutar

@soutar soutar commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

`fireReview` receives the label flag but drops it (`_byLabel` unused) and hardcodes `force: false` into `runReview`. Labeling a PR whose head SHA is already in `reviewedShas` therefore logs "already reviewed" and does nothing — the explicit re-review path can never deliver a re-review. One-line fix: pass the flag through as `force`. Automatic paths (`synchronize`, reconcile, preflight) still pass `false`, so dedup and push-debounce behavior are unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QioQmE91ZTAfnobuTeMD5L

fireReview received the label flag but dropped it, so labeling a PR whose
head SHA was already in reviewedShas logged "already reviewed" and did
nothing — the one path that exists to explicitly request a fresh review
could never deliver one. Pass the flag through as runReview's force.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01QioQmE91ZTAfnobuTeMD5L
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
opensession Ready Ready Preview Sep 7, 2026 3:03pm UTC

@open-session-os-tella-dev

open-session-os-tella-dev Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🤖 OS review · approve · quality 5/5 · risk low

Safe to merge.

🟢 Risk low · recovery in minutes · no tests
Runtime webhook behavior changes by forwarding byLabel to runReview, with no test changes shown.

Reviewed 9b5d6c7 · GPT-5.6 Sol · open session · labels: os-auto-fix fix and push · os-adversarial deeper pass · os-simplify cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant