Keep the credential permission test independent of the caller umask. - #3
Open
tral wants to merge 1 commit into
Open
Keep the credential permission test independent of the caller umask.#3tral wants to merge 1 commit into
tral wants to merge 1 commit into
Conversation
The installer runs with umask 077, so os.WriteFile could not create the group/other-readable profiles file the second half of the test relies on: the mode landed at 0400, Load correctly accepted it, and the assertion that a permissive file outside a credential directory is rejected failed. go test ./... therefore aborted every installation from a clean checkout. Restore the intended mode with an explicit chmod. The permission check in loadProfiles is unchanged; only the fixture was umask-sensitive. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer runs with umask 077, so os.WriteFile could not create the group/other-readable profiles file the second half of the test relies on: the mode landed at 0400, Load correctly accepted it, and the assertion that a permissive file outside a credential directory is rejected failed. go test ./... therefore aborted every installation from a clean checkout.
Restore the intended mode with an explicit chmod. The permission check in loadProfiles is unchanged; only the fixture was umask-sensitive.