Skip to content

fix(tektonconfig): make platform subtrees pointers - #3962

Open
anchi205 wants to merge 1 commit into
tektoncd:mainfrom
anchi205:fix/SRVKP-11787
Open

fix(tektonconfig): make platform subtrees pointers#3962
anchi205 wants to merge 1 commit into
tektoncd:mainfrom
anchi205:fix/SRVKP-11787

Conversation

@anchi205

Copy link
Copy Markdown
Contributor

Changes

Convert spec.platforms.openshift and spec.platforms.kubernetes to pointer types so the stored TektonConfig only persists the subtree for the running platform.

The PipelinesAsCode artifact pre-upgrade now runs on Kubernetes as well as OpenShift, cleaning hub-catalog-name from whichever platform's PaC spec is set.

Submitter Checklist

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 21, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign anithapriyanatarajan after the PR has been reviewed.
You can assign the PR to them by writing /assign @anithapriyanatarajan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.36%. Comparing base (3901432) to head (dda4074).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3962      +/-   ##
==========================================
+ Coverage   26.33%   26.36%   +0.02%     
==========================================
  Files         465      465              
  Lines       24951    24973      +22     
==========================================
+ Hits         6572     6583      +11     
- Misses      17661    17671      +10     
- Partials      718      719       +1     
Flag Coverage Δ
unit-tests 26.36% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2026
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 21, 2026
Convert spec.platforms.openshift and spec.platforms.kubernetes to
pointer types so the stored TektonConfig only persists the subtree
for the running platform.

The PipelinesAsCode artifact pre-upgrade now runs on Kubernetes as
well as OpenShift, cleaning hub-catalog-name from whichever
platform's PaC spec is set.

Signed-off-by: Anchita Borah <[email protected]>
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants