Skip to content

fix(pipeline): validate resolver ordinal buckets - #3958

Open
waveywaves wants to merge 1 commit into
tektoncd:mainfrom
waveywaves:fix-resolver-ordinal-bucket-validation
Open

fix(pipeline): validate resolver ordinal buckets#3958
waveywaves wants to merge 1 commit into
tektoncd:mainfrom
waveywaves:fix-resolver-ordinal-bucket-validation

Conversation

@waveywaves

Copy link
Copy Markdown
Member

Changes

  • Validate the effective resolver leader-election bucket count against the rendered resolver StatefulSet replica count after additional options are applied.
  • Preserve matching overrides and dynamic leader-election configurations.
  • Reject out-of-range bucket overrides in StatefulSet ordinal mode.

The existing performance documentation already states that buckets must match replicas in ordinal mode.

Fixes #3957.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Validate that resolver leader-election buckets match resolver replicas when StatefulSet ordinal mode is enabled.

Validate the effective resolver bucket count against the rendered
StatefulSet replicas after additional options are applied.

This prevents ordinal mode from leaving resolver buckets without owners.

Signed-off-by: Vibhav Bobade <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 20, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign savitaashture after the PR has been reviewed.
You can assign the PR to them by writing /assign @savitaashture in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.41%. Comparing base (dd7faf7) to head (3b434b0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3958      +/-   ##
==========================================
+ Coverage   26.33%   26.41%   +0.07%     
==========================================
  Files         465      465              
  Lines       24951    24979      +28     
==========================================
+ Hits         6572     6597      +25     
  Misses      17661    17661              
- Partials      718      721       +3     
Flag Coverage Δ
unit-tests 26.41% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waveywaves
waveywaves marked this pull request as draft August 20, 2026 13:28
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2026
@waveywaves
waveywaves marked this pull request as ready for review August 20, 2026 15:44
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolver requests time out when ordinal-mode bucket overrides exceed replicas

2 participants