Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Slow Read DoS vulnerability (Missing Write Deadline) - #9

Open
tejjasdev wants to merge 1 commit into
mainfrom
fix/slow-read-dos-deadline-4002513079532924682
Open

tejjasdev wants to merge 1 commit into
mainfrom
fix/slow-read-dos-deadline-4002513079532924682

Conversation

@tejjasdev

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The HTTP server lacked a write deadline (write timeout) for default responses, making it vulnerable to Slow Read Denial of Service (DoS) attacks.
🎯 Impact: An attacker could intentionally read response bytes slowly, holding open server connections indefinitely and potentially exhausting server resources.
πŸ”§ Fix: unconditionally invoke SetWriteDeadline via http.NewResponseController(w) for both standard responses and CORS preflight requests.
βœ… Verification: Covered by existing server test suite; confirmed via make check.


PR created automatically by Jules for task 4002513079532924682 started by @tejjasdev

Added a strict write deadline to all outgoing responses (both standard and CORS preflight) using `http.NewResponseController`. Previously, write deadlines were only set if the user had configured an artificial response delay, leaving standard immediate responses vulnerable to Slow Read DoS attacks.

Co-authored-by: tejjasdev <[email protected]>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant