Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Enhance security for exported requests - #12

Open
tejjasdev wants to merge 1 commit into
mainfrom
sentinel/enhance-export-security-8046021840658410554
Open

tejjasdev wants to merge 1 commit into
mainfrom
sentinel/enhance-export-security-8046021840658410554

Conversation

@tejjasdev

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Saved HTTP requests were stored in directories created with 0o755 permissions, meaning other users on the same machine could read the saved request files. In addition, the Set-Cookie header was not redacted by default.
🎯 Impact: This could potentially lead to information disclosure if a sensitive request (with tokens or sensitive payloads) is saved locally on a shared machine.
πŸ”§ Fix:

  • Changed os.MkdirAll permission from 0o755 to 0o700 in internal/export/export.go.
  • Added Set-Cookie to DefaultRedactHeaders.
    βœ… Verification: make test passes successfully, and review shows standard library features used appropriately for securing the exported files.

PR created automatically by Jules for task 8046021840658410554 started by @tejjasdev

- Changes directory creation permission for saved HTTP requests from `0o755` to `0o700` in `internal/export/export.go` to prevent unauthorized access by other local users.
- Adds `Set-Cookie` to the default list of redacted headers to prevent potential leakage of sensitive server-set session data in exports.

Co-authored-by: tejjasdev <[email protected]>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant