Repository navigation
Conversation
Add write deadlines to all HTTP responses to prevent slow readers from keeping connections open indefinitely. Previously, write deadlines were only set for responses with a configured delay. This change ensures that both CORS preflight responses and normal immediate responses also enforce a 30-second write timeout. Co-authored-by: tejjasdev <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Missing HTTP write deadlines allowed slow clients to keep connections open indefinitely (slowloris-style attack).
🎯 Impact: An attacker could exhaust server resources by initiating requests and reading the response very slowly.
🔧 Fix: Used
http.NewResponseControllerto explicitly set a write deadline for all paths inServeHTTP, including CORS preflight and immediate responses.✅ Verification:
make checkpasses, confirming no functionality is broken and tests succeed.PR created automatically by Jules for task 10665407926583295208 started by @tejjasdev