iris-gui: port live MIPS estimate to CyclesPtr

[tenox7]

Problem

iris-gui doesn't compile on current main:

error[E0308]: mismatched types
   --> iris-gui/src/handle.rs:409:34
    |
409 |                         cycles = m.get_rex3().map(|r| r.cycles.clone());
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Option<Arc<Atomic<u64>>>`, found `Option<Cell<CyclesPtr>>`
error: could not compile `iris-gui` (bin "iris-gui") due to 1 previous error

926d56f ("convert cycles atomic into regular volatile variable") changed Rex3::cycles from Arc<AtomicU64> to Cell<CyclesPtr> across 11 files under src/, but iris-gui/ wasn't updated. The GUI's worker loop uses that counter for its live MIPS estimate, so it was still calling .clone() on the Arc and .load(Ordering::Relaxed) to read it.

The CLI (iris, iris-ci) builds fine — only the GUI is affected.

Fix

Latch the CyclesPtr by value rather than cloning an Arc, and read it with .get():

let mut cycles: Option<iris::mips_core::CyclesPtr> = None;
...
cycles = m.get_rex3().map(|r| r.cycles.get());
prev_cycles = cycles.map(|c| c.get()).unwrap_or(0);

This mirrors REX3's own refresh thread at src/rex3.rs:3863 (self.cycles.get().get() — Cell::get for the pointer, then CyclesPtr::get for the count).

Notes on correctness:

• CyclesPtr is Copy/Send/Sync and its doc comment names cross-thread status displays as the intended consumer, valid for the process lifetime. The GUI's MIPS readout is exactly that — it exists because the GUI never runs REX3's own refresh/status-bar loop.
• Being Copy, the Option no longer needs .as_ref().
• .get() is null-safe (returns 0 while dangling), and the pointer is already wired up by the time the GUI latches it, since that happens after Machine::new returns.
• The existing Stop/SyncDisks paths already reset cycles = None before the machine is dropped, so no dangling read.

Testing

./build.sh on macOS arm64 (rustc 1.99.0-nightly), CLI features lightning,rex-jit,tlbvmap,idle-pause and GUI features iris/lightning,iris/idle-pause: all three binaries build clean. No new warnings.

[Copilot]

Pull request overview

Updates iris-gui to match the emulator core’s newer cycle-counter plumbing by switching the GUI’s live MIPS estimate from an Arc<AtomicU64>-based counter to the mips_core::CyclesPtr pointer-based counter used by REX3.

Changes:

• Replace the GUI worker-loop cached cycle counter type from Option<Arc<AtomicU64>> to Option<iris::mips_core::CyclesPtr>.
• Update the periodic MIPS-estimate refresh logic to read cycles via CyclesPtr::get() instead of AtomicU64::load(Ordering::Relaxed).
• Latch the cycle counter from REX3 via r.cycles.get() (copying the pointer value out of the Cell) and initialize prev_cycles via CyclesPtr::get().

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[techomancer]

oh crap. sorry