fix: correct Zeo++ engine arguments and output handling - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zeo++ requests with different channel and probe radii currently send those values in reverse order. Documented multiline channel output fails parsing, and default PSD output is missed because MatKit looks for
.psdinstead of.psd_histo.This change shares argument construction and output validation between the legacy and unified APIs, corrects radius ordering, supports the documented output formats, and rejects incomplete or nonfinite requested results. Existing result keys and explicitly named legacy
.psdfiles remain supported.Validation: 50 focused Zeo++ tests passed; source lint and diff checks passed. The combined three-fix wheel suite passed 393 tests with 1 skipped outside the checkout. Regression fixtures and synthetic subprocesses do not establish real Zeo++ execution or scientific accuracy.
Engine format reference: https://www.zeoplusplus.org/examples.html