Repository navigation
Revert "Deprecate usage of Mat_VarCreateStruct in favor of Mat_VarCreateStruct2 - #375
Merged
Merged
Conversation
tbeu
approved these changes
Sep 28, 2026
tbeu
force-pushed
the
revert-api-deprecation
branch
from
October 1, 2026 20:38
a391ba8 to
833cb85
Compare
tbeu
reviewed
Oct 1, 2026
tbeu
left a comment
tbeu
left a comment
Owner
There was a problem hiding this comment.
Thanks for PR.
I guess adding write_struct2_char to test_mat is not needed. It is not called and also misses help text though. test_mat could stay as is.
…ateStruct2" This only reverts the deprecations of Mat_VarCreateStruct in commit 41b5054.
Febbe
force-pushed
the
revert-api-deprecation
branch
from
October 1, 2026 22:02
833cb85 to
a0e4434
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only reverts the deprecations of Mat_VarCreateStruct in commit 41b5054.
Merge after #374
Fixes #373